From: Oscar Salvador <osalvador@techadventures.net>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: mhocko@suse.com, vbabka@suse.cz, dan.j.williams@intel.com,
yasu.isimatu@gmail.com, jonathan.cameron@huawei.com,
david@redhat.com, linux-mm@kvack.org,
linux-kernel@vger.kernel.org, Oscar Salvador <osalvador@suse.de>
Subject: Re: [PATCH 3/3] mm/memory_hotplug: Cleanup unregister_mem_sect_under_nodes
Date: Sat, 11 Aug 2018 10:08:46 +0200 [thread overview]
Message-ID: <20180811080846.GA24835@techadventures.net> (raw)
In-Reply-To: <20180810153727.c9ae4aab518f1b84e04c999a@linux-foundation.org>
On Fri, Aug 10, 2018 at 03:37:27PM -0700, Andrew Morton wrote:
> I guess so. But the node_online() check was silently removed?
A node can only get offline if all the memory and CPUs associated
with it are removed.
This is being checked in remove_memory()->try_offline_node().
There we check whether the node has still valid sections or not,
and if there are still CPUs associated to it.
In the case that either we still have valid sections or that we have
CPUs linked to this node, we do not offline it.
So we cannot really be removing a memory from a node that is offline,
that is why it is safe to drop the check.
It was my mistake not to explain that properly in the changelog though.
I will send a V2 fixing up all you pointed out and explaining
why it is safe to drop the check.
Thanks
--
Oscar Salvador
SUSE L3
next prev parent reply other threads:[~2018-08-11 8:08 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-10 15:29 [PATCH 0/3] Refactor/cleanup for remove_memory_section/unregister_mem_sect_under_nodes osalvador
2018-08-10 15:29 ` [PATCH 1/3] mm/memory_hotplug: Drop unused args from remove_memory_section osalvador
2018-08-10 15:29 ` [PATCH 2/3] mm/memory_hotplug: Drop unneeded check from unregister_mem_sect_under_nodes osalvador
2018-08-10 15:29 ` [PATCH 3/3] mm/memory_hotplug: Cleanup unregister_mem_sect_under_nodes osalvador
2018-08-10 22:37 ` Andrew Morton
2018-08-11 8:08 ` Oscar Salvador [this message]
2018-08-13 8:55 ` Oscar Salvador
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180811080846.GA24835@techadventures.net \
--to=osalvador@techadventures.net \
--cc=akpm@linux-foundation.org \
--cc=dan.j.williams@intel.com \
--cc=david@redhat.com \
--cc=jonathan.cameron@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=osalvador@suse.de \
--cc=vbabka@suse.cz \
--cc=yasu.isimatu@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).