From: David Miller <davem@davemloft.net>
To: zong@andestech.com
Cc: rostedt@goodmis.org, mingo@redhat.com, dsahern@gmail.com,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
zongbox@gmail.com, greentime@andestech.com
Subject: Re: [PATCH] net: Change the layout of structure trace_event_raw_fib_table_lookup
Date: Mon, 13 Aug 2018 09:37:02 -0700 (PDT) [thread overview]
Message-ID: <20180813.093702.2205532109074390272.davem@davemloft.net> (raw)
In-Reply-To: <1534127212-13186-1-git-send-email-zong@andestech.com>
From: Zong Li <zong@andestech.com>
Date: Mon, 13 Aug 2018 10:26:52 +0800
> There is an unalignment access about the structure
> 'trace_event_raw_fib_table_lookup'.
>
> In include/trace/events/fib.h, there is a memory operation which casting
> the 'src' data member to a pointer, and then store a value to this
> pointer point to.
>
> p32 = (__be32 *) __entry->src;
> *p32 = flp->saddr;
>
> The offset of 'src' in structure trace_event_raw_fib_table_lookup is not
> four bytes alignment. On some architectures, they don't permit the
> unalignment access, it need to pay the price to handle this situation in
> exception handler.
>
> Adjust the layout of structure to avoid this case.
>
> Signed-off-by: Zong Li <zong@andestech.com>
Applied, with Fixes tag from David added.
prev parent reply other threads:[~2018-08-13 16:37 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 2:26 [PATCH] net: Change the layout of structure trace_event_raw_fib_table_lookup Zong Li
2018-08-13 14:40 ` David Ahern
2018-08-14 1:13 ` Zong Li
2018-08-13 16:37 ` David Miller [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180813.093702.2205532109074390272.davem@davemloft.net \
--to=davem@davemloft.net \
--cc=dsahern@gmail.com \
--cc=greentime@andestech.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=rostedt@goodmis.org \
--cc=zong@andestech.com \
--cc=zongbox@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).