From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 38A5BC46460 for ; Tue, 14 Aug 2018 03:44:39 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id F09442083C for ; Tue, 14 Aug 2018 03:44:38 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org F09442083C Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=davemloft.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731101AbeHNG3e (ORCPT ); Tue, 14 Aug 2018 02:29:34 -0400 Received: from shards.monkeyblade.net ([23.128.96.9]:38120 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728166AbeHNG3e (ORCPT ); Tue, 14 Aug 2018 02:29:34 -0400 Received: from localhost (unknown [172.58.41.230]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 52BEF12173DA1; Mon, 13 Aug 2018 20:44:21 -0700 (PDT) Date: Mon, 13 Aug 2018 20:44:20 -0700 (PDT) Message-Id: <20180813.204420.1246202084626536095.davem@davemloft.net> To: arnd@arndb.de Cc: bryan.whitehead@microchip.com, UNGLinuxDriver@microchip.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH 2/2] net: lan743x: fix building without CONFIG_PTP_1588_CLOCK From: David Miller In-Reply-To: <20180813211938.2375199-2-arnd@arndb.de> References: <20180813211938.2375199-1-arnd@arndb.de> <20180813211938.2375199-2-arnd@arndb.de> X-Mailer: Mew version 6.7 on Emacs 26 / Mule 6.0 (HANACHIRUSATO) Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Mon, 13 Aug 2018 20:44:21 -0700 (PDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Arnd Bergmann Date: Mon, 13 Aug 2018 23:19:22 +0200 > Building without CONFIG_PTP_1588_CLOCK results in multiple failures, > this was obviously not well tested: ... > Those #ifdef checks are hard to get right, replace them all with > IS_ENABLED() checks that leave the same code visible to the compiler > but let it optimize out the unused bits based on the configuration. > > Fixes: 07624df1c9ef ("lan743x: lan743x: Add PTP support") > Signed-off-by: Arnd Bergmann Applied.