From: Johan Hovold <johan@kernel.org>
To: Alexandre Belloni <alexandre.belloni@bootlin.com>
Cc: Keerthy <j-keerthy@ti.com>,
a.zummo@towertech.it, t-kristo@ti.com, linux-rtc@vger.kernel.org,
linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org,
johan@kernel.org
Subject: Re: [PATCH v5 2/2] rtc: omap: Cut down the shutdown time from 2 seconds to 1 sec
Date: Tue, 14 Aug 2018 11:27:55 +0200 [thread overview]
Message-ID: <20180814092755.GB30344@localhost> (raw)
In-Reply-To: <20180725093018.GA3539@piout.net>
On Wed, Jul 25, 2018 at 11:30:18AM +0200, Alexandre Belloni wrote:
> Hi,
>
> On 25/07/2018 11:21:22+0530, Keerthy wrote:
> > Cut down the shutdown time from 2 seconds to 1 sec. In case of roll
> > over try again.
> >
> > Signed-off-by: Keerthy <j-keerthy@ti.com>
> > static void omap_rtc_power_off(void)
> > @@ -435,17 +429,20 @@ static void omap_rtc_power_off(void)
> > struct rtc_time tm;
> > unsigned long now;
> > u32 val;
> > + int seconds;
> >
> > rtc->type->unlock(rtc);
> > /* enable pmic_power_en control */
> > val = rtc_readl(rtc, OMAP_RTC_PMIC_REG);
> > rtc_writel(rtc, OMAP_RTC_PMIC_REG, val | OMAP_RTC_PMIC_POWER_EN_EN);
> >
> > - /* set alarm two seconds from now */
> > +again:
> > + /* set alarm one second from now */
> > omap_rtc_read_time_raw(rtc, &tm);
> > + seconds = tm.tm_sec;
> > bcd2tm(&tm);
> > rtc_tm_to_time(&tm, &now);
> > - rtc_time_to_tm(now + 2, &tm);
> > + rtc_time_to_tm(now + 1, &tm);
> >
> > if (tm2bcd(&tm) < 0) {
> > dev_err(&rtc->rtc->dev, "power off failed\n");
> > @@ -470,14 +467,25 @@ static void omap_rtc_power_off(void)
> > val = rtc_read(rtc, OMAP_RTC_INTERRUPTS_REG);
> > rtc_writel(rtc, OMAP_RTC_INTERRUPTS_REG,
> > val | OMAP_RTC_INTERRUPTS_IT_ALARM2);
> > +
> > + /*
> > + * first check if ALARM2 has fired, if not then check if
> > + * our calculations started right before the rollover, try again
> > + * in case of rollover
> > + */
> > + if (!(OMAP_RTC_STATUS_ALARM2 && rtc_read(omap_rtc_power_off_rtc,
> > + OMAP_RTC_STATUS_REG)) &&
> > + seconds != rtc_read(omap_rtc_power_off_rtc, OMAP_RTC_SECONDS_REG))
> > + goto again;
> > +
>
> Can you use a while loop instead of goto?
I think a goto is warranted here as it allows for more readable code
with less indentation. And the exception case it is used for is truly an
exception that a single retry would take care of.
Johan
next prev parent reply other threads:[~2018-08-14 9:28 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-25 5:51 [PATCH v5 1/2] rtc: omap: use of_device_is_system_power_controller function Keerthy
2018-07-25 5:51 ` [PATCH v5 2/2] rtc: omap: Cut down the shutdown time from 2 seconds to 1 sec Keerthy
2018-07-25 9:30 ` Alexandre Belloni
2018-08-14 9:27 ` Johan Hovold [this message]
2018-08-14 9:32 ` Keerthy
2018-08-14 9:23 ` Johan Hovold
2018-08-14 9:54 ` Keerthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814092755.GB30344@localhost \
--to=johan@kernel.org \
--cc=a.zummo@towertech.it \
--cc=alexandre.belloni@bootlin.com \
--cc=j-keerthy@ti.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=t-kristo@ti.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).