From: Alexandre Belloni <alexandre.belloni@bootlin.com>
To: zhong jiang <zhongjiang@huawei.com>
Cc: nicolas.ferre@microchip.com, linux@armlinux.org.uk,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] arm/mach-at91/pm: Do not double put the device node
Date: Tue, 14 Aug 2018 14:59:54 +0200 [thread overview]
Message-ID: <20180814125954.GM943@piout.net> (raw)
In-Reply-To: <1534211696-4221-1-git-send-email-zhongjiang@huawei.com>
On 14/08/2018 09:54:56+0800, zhong jiang wrote:
> Device node iterators put the previous value of the index variable,
> so an explicit put causes a double put.
>
While for_each_matching_node_and_match will get and put the node
properly, there is also a call to of_find_device_by_node that will get a
reference to the node.
> I detect the issue with the help of Coccinelle.
>
> Signed-off-by: zhong jiang <zhongjiang@huawei.com>
> ---
> arch/arm/mach-at91/pm.c | 5 +----
> 1 file changed, 1 insertion(+), 4 deletions(-)
>
> diff --git a/arch/arm/mach-at91/pm.c b/arch/arm/mach-at91/pm.c
> index 32fae4d..a5ec35f 100644
> --- a/arch/arm/mach-at91/pm.c
> +++ b/arch/arm/mach-at91/pm.c
> @@ -143,15 +143,12 @@ static int at91_pm_config_ws(unsigned int pm_mode, bool set)
>
> /* Check if enabled on SHDWC. */
> if (wsi->shdwc_mr_bit && !(val & wsi->shdwc_mr_bit))
> - goto put_node;
> + continue;
>
> mode |= wsi->pmc_fsmr_bit;
> if (wsi->set_polarity)
> polarity |= wsi->pmc_fsmr_bit;
> }
> -
> -put_node:
> - of_node_put(np);
> }
>
> if (mode) {
> --
> 1.7.12.4
>
--
Alexandre Belloni, Bootlin
Embedded Linux and Kernel engineering
https://bootlin.com
next prev parent reply other threads:[~2018-08-14 13:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 1:54 [PATCH] arm/mach-at91/pm: Do not double put the device node zhong jiang
2018-08-14 12:59 ` Alexandre Belloni [this message]
2018-08-16 9:32 ` Claudiu Beznea
2018-08-16 10:18 ` zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814125954.GM943@piout.net \
--to=alexandre.belloni@bootlin.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=nicolas.ferre@microchip.com \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).