From: Chengguang Xu <cgxu519@gmx.com>
To: jack@suse.com, tytso@mit.edu, adilger.kernel@dilger.ca,
jaegeuk@kernel.org, yuchao0@huawei.com, shaggy@kernel.org,
hubcap@omnibond.com, martin@omnibond.com
Cc: devel@lists.orangefs.org, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
jfs-discussion@lists.sourceforge.net,
Chengguang Xu <cgxu519@gmx.com>
Subject: [PATCH 5/5] orangefs: cache NULL when both default_acl and acl are NULL
Date: Tue, 14 Aug 2018 22:16:34 +0800 [thread overview]
Message-ID: <20180814141634.5471-5-cgxu519@gmx.com> (raw)
In-Reply-To: <20180814141634.5471-1-cgxu519@gmx.com>
default_acl and acl of newly created inode will be initiated
as ACL_NOT_CACHED in vfs function inode_init_always() and later
will be updated by calling xxx_init_acl() in specific filesystems.
Howerver, when default_acl and acl are NULL then they keep the value
of ACL_NOT_CACHED, this patch tries to cache NULL for acl/default_acl
in this case.
Signed-off-by: Chengguang Xu <cgxu519@gmx.com>
---
fs/orangefs/acl.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/fs/orangefs/acl.c b/fs/orangefs/acl.c
index 10587413b20e..e3b043a263bc 100644
--- a/fs/orangefs/acl.c
+++ b/fs/orangefs/acl.c
@@ -175,6 +175,9 @@ int orangefs_init_acl(struct inode *inode, struct inode *dir)
posix_acl_release(acl);
}
+ if (!default_acl && !acl)
+ cache_no_acl(inode);
+
/* If mode of the inode was changed, then do a forcible ->setattr */
if (mode != inode->i_mode) {
memset(&iattr, 0, sizeof iattr);
--
2.17.1
next prev parent reply other threads:[~2018-08-14 14:18 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 14:16 [PATCH 1/5] ext2: cache NULL when both default_acl and acl are NULL Chengguang Xu
2018-08-14 14:16 ` [PATCH 2/5] ext4: " Chengguang Xu
2018-08-14 14:16 ` [PATCH 3/5] f2fs: " Chengguang Xu
2018-08-14 14:16 ` [PATCH 4/5] jfs: " Chengguang Xu
2018-08-14 14:16 ` Chengguang Xu [this message]
2018-08-29 13:18 ` [PATCH 1/5] ext2: " Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814141634.5471-5-cgxu519@gmx.com \
--to=cgxu519@gmx.com \
--cc=adilger.kernel@dilger.ca \
--cc=devel@lists.orangefs.org \
--cc=hubcap@omnibond.com \
--cc=jack@suse.com \
--cc=jaegeuk@kernel.org \
--cc=jfs-discussion@lists.sourceforge.net \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=martin@omnibond.com \
--cc=shaggy@kernel.org \
--cc=tytso@mit.edu \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).