From: Jaegeuk Kim <jaegeuk@kernel.org>
To: Chao Yu <yuchao0@huawei.com>
Cc: linux-f2fs-devel@lists.sourceforge.net,
linux-kernel@vger.kernel.org, chao@kernel.org
Subject: Re: [PATCH] Revert "f2fs: use printk_ratelimited for f2fs_msg"
Date: Tue, 14 Aug 2018 10:09:56 -0700 [thread overview]
Message-ID: <20180814170956.GA56510@jaegeuk-macbookpro.roam.corp.google.com> (raw)
In-Reply-To: <20180813062845.25394-1-yuchao0@huawei.com>
On 08/13, Chao Yu wrote:
> Don't limit printing log, so that we will not miss any key messages.
For example, this can avoid lots of messages during roll-forward recovery.
>
> This reverts commit a36c106dffb616250117efb1cab271c19a8f94ff.
>
> Signed-off-by: Chao Yu <yuchao0@huawei.com>
> ---
> fs/f2fs/super.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/f2fs/super.c b/fs/f2fs/super.c
> index bf4c919fe418..3d89d94191e7 100644
> --- a/fs/f2fs/super.c
> +++ b/fs/f2fs/super.c
> @@ -209,7 +209,7 @@ void f2fs_msg(struct super_block *sb, const char *level, const char *fmt, ...)
> va_start(args, fmt);
> vaf.fmt = fmt;
> vaf.va = &args;
> - printk_ratelimited("%sF2FS-fs (%s): %pV\n", level, sb->s_id, &vaf);
> + printk("%sF2FS-fs (%s): %pV\n", level, sb->s_id, &vaf);
> va_end(args);
> }
>
> --
> 2.18.0.rc1
next prev parent reply other threads:[~2018-08-14 17:10 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 6:28 [PATCH] Revert "f2fs: use printk_ratelimited for f2fs_msg" Chao Yu
2018-08-13 9:50 ` Joe Perches
2018-08-14 7:53 ` Chao Yu
2018-08-14 17:09 ` Jaegeuk Kim [this message]
2018-08-15 1:19 ` Chao Yu
2018-08-15 3:01 ` Jaegeuk Kim
2018-08-15 3:11 ` Chao Yu
2018-08-15 3:25 ` Jaegeuk Kim
2018-08-15 3:42 ` Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814170956.GA56510@jaegeuk-macbookpro.roam.corp.google.com \
--to=jaegeuk@kernel.org \
--cc=chao@kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-kernel@vger.kernel.org \
--cc=yuchao0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).