From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6613CC46464 for ; Tue, 14 Aug 2018 19:27:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 18D0B21732 for ; Tue, 14 Aug 2018 19:27:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 18D0B21732 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=codewreck.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728573AbeHNWQZ (ORCPT ); Tue, 14 Aug 2018 18:16:25 -0400 Received: from nautica.notk.org ([91.121.71.147]:51331 "EHLO nautica.notk.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725973AbeHNWQZ (ORCPT ); Tue, 14 Aug 2018 18:16:25 -0400 Received: by nautica.notk.org (Postfix, from userid 1001) id 769D8C009; Tue, 14 Aug 2018 21:27:43 +0200 (CEST) Date: Tue, 14 Aug 2018 21:27:28 +0200 From: Dominique Martinet To: Daniel =?utf-8?B?RMOtYXo=?= Cc: Thomas Renninger , Shuah Khan , Colin Ian King , linux-pm@vger.kernel.org, open list Subject: Re: [PATCH 18/18] cpupower: change strncpy+truncation to strlcpy Message-ID: <20180814192728.GA6264@nautica> References: <1531444483-17338-1-git-send-email-asmadeus@codewreck.org> <1531445169-19912-1-git-send-email-asmadeus@codewreck.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Daniel Díaz wrote on Tue, Aug 14, 2018: > I can't get cpupower to compile anymore now that it made its way to linux-next: > [/linux/tools/power/cpupower]$ make > CC lib/cpufreq.o > [...] > make[1]: Entering directory '/linux/tools/power/cpupower/bench' > CC main.o > CC parse.o > parse.c: In function ‘prepare_config’: > parse.c:224:4: warning: implicit declaration of function ‘strlcpy’ > [-Wimplicit-function-declaration] > strlcpy(config->governor, val, > ^ > CC system.o > CC benchmark.o > CC cpufreq-bench > .//parse.o: In function `prepare_config': > /linux/tools/power/cpupower/bench/parse.c:224: undefined reference > to `strlcpy' > collect2: error: ld returned 1 exit status > Makefile:25: recipe for target 'cpufreq-bench' failed > make[1]: *** [cpufreq-bench] Error 1 > make[1]: Leaving directory '/linux/tools/power/cpupower/bench' > Makefile:258: recipe for target 'compile-bench' failed > make: *** [compile-bench] Error 2 > > Does it need anything special to make? Ugh, no, I am really ashamed about this patch series for insufficient testing in general. It is currently "under rework" for an indefinite time frame as I have had other priorities but I'll add cpupower to the list... More precisely, the function is defined in the linux kernel but for userspace strlcpy is only available through libbsd, and I don't believe we should pull that in just for this. I'll send a second patch using snprintf and warning if a truncation occurs (which is the proper fix that the gcc folks intended people to do anyway) when I get around to it, but I would recommend to just revert the patch for now. Shuah, could you take the patch off please if you haven't pushed it to linus yet? Sorry for the time you might have spent on this, -- Dominique Martinet