* [PATCH] cpu/hotplug: Non-SMP machines do not make use of booted_once
@ 2018-08-14 21:26 Abel Vesa
2018-08-14 21:43 ` Linus Torvalds
0 siblings, 1 reply; 2+ messages in thread
From: Abel Vesa @ 2018-08-14 21:26 UTC (permalink / raw)
To: Thomas Gleixner, Linus Torvalds
Cc: Peter Zijlstra, Ingo Molnar, Lai Jiangshan, Brendan Jackman,
Arnd Bergmann, linux-kernel
Following commit breaks the non-SMP builds.
[0cc3cd21657be04cb0] cpu/hotplug: Boot HT siblings at least once
Signed-off-by: Abel Vesa <abelvesa@linux.com>
---
kernel/cpu.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/kernel/cpu.c b/kernel/cpu.c
index 099fb20cd7be..f06c513c5c42 100644
--- a/kernel/cpu.c
+++ b/kernel/cpu.c
@@ -2272,6 +2272,8 @@ void __init boot_cpu_init(void)
*/
void __init boot_cpu_hotplug_init(void)
{
+#ifdef CONFIG_SMP
this_cpu_write(cpuhp_state.booted_once, true);
+#endif
this_cpu_write(cpuhp_state.state, CPUHP_ONLINE);
}
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] cpu/hotplug: Non-SMP machines do not make use of booted_once
2018-08-14 21:26 [PATCH] cpu/hotplug: Non-SMP machines do not make use of booted_once Abel Vesa
@ 2018-08-14 21:43 ` Linus Torvalds
0 siblings, 0 replies; 2+ messages in thread
From: Linus Torvalds @ 2018-08-14 21:43 UTC (permalink / raw)
To: abelvesa
Cc: Thomas Gleixner, Peter Zijlstra, Ingo Molnar, Lai Jiangshan,
brendan.jackman, Arnd Bergmann, Linux Kernel Mailing List
On Tue, Aug 14, 2018 at 2:26 PM Abel Vesa <abelvesa@linux.com> wrote:
>
> Following commit breaks the non-SMP builds.
Thanks, we obviously don't do a lot of coverage of UP any more.
I'm not sure if we should just move the bool's to be bitfields and
make them all available unconditionally, because the #ifdef in code
annoys me.
I'll think about it. The x86 maintainers are all on vacation this
week, and I don't want to disturb them, so I'll fix it one way or
another.
Linus
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-14 21:44 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-14 21:26 [PATCH] cpu/hotplug: Non-SMP machines do not make use of booted_once Abel Vesa
2018-08-14 21:43 ` Linus Torvalds
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).