From: Brian Norris <computersforpeace@gmail.com>
To: Rob Herring <robh+dt@kernel.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Rafael J. Wysocki" <rafael@kernel.org>
Cc: Andrew Lunn <andrew@lunn.ch>,
Florian Fainelli <f.fainelli@gmail.com>,
Dmitry Torokhov <dmitry.torokhov@gmail.com>,
Guenter Roeck <linux@roeck-us.net>,
netdev@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Julius Werner <jwerner@chromium.org>,
Stephen Boyd <swboyd@chromium.org>,
Brian Norris <briannorris@chromium.org>
Subject: [RFC PATCH v1 3/3] firmware: vpd: add MAC address parser
Date: Tue, 14 Aug 2018 15:37:58 -0700 [thread overview]
Message-ID: <20180814223758.117433-4-briannorris@chromium.org> (raw)
In-Reply-To: <20180814223758.117433-1-briannorris@chromium.org>
Device trees can now specify their MAC address via something like:
mac-address-lookup = "vpd:wifi_mac0";
instead of requiring boot firmware to parse and splice the FDT itself.
Signed-off-by: Brian Norris <briannorris@chromium.org>
---
drivers/firmware/google/vpd.c | 67 +++++++++++++++++++++++++++++++++++
1 file changed, 67 insertions(+)
diff --git a/drivers/firmware/google/vpd.c b/drivers/firmware/google/vpd.c
index e9db895916c3..b2b08497db32 100644
--- a/drivers/firmware/google/vpd.c
+++ b/drivers/firmware/google/vpd.c
@@ -16,6 +16,7 @@
*/
#include <linux/ctype.h>
+#include <linux/if_ether.h>
#include <linux/init.h>
#include <linux/io.h>
#include <linux/kernel.h>
@@ -24,6 +25,7 @@
#include <linux/module.h>
#include <linux/of_address.h>
#include <linux/platform_device.h>
+#include <linux/property.h>
#include <linux/slab.h>
#include <linux/sysfs.h>
@@ -173,6 +175,36 @@ static ssize_t vpd_section_read(struct file *filp, struct kobject *kobp,
sec->bin_attr.size);
}
+static const char *__vpd_get_entry(struct vpd_section *sec, const char *key)
+{
+ struct vpd_attrib_info *info;
+
+ list_for_each_entry(info, &sec->attribs, list)
+ if (!strcmp(info->key, key))
+ return info->value;
+
+ return NULL;
+}
+
+static const char *vpd_get_entry(const char *key)
+{
+ const char *value;
+
+ if (rw_vpd.enabled) {
+ value = __vpd_get_entry(&rw_vpd, key);
+ if (value)
+ return value;
+ }
+
+ if (ro_vpd.enabled) {
+ value = __vpd_get_entry(&ro_vpd, key);
+ if (value)
+ return value;
+ }
+
+ return NULL;
+}
+
static int vpd_section_create_attribs(struct vpd_section *sec)
{
s32 consumed;
@@ -286,6 +318,37 @@ static int vpd_sections_init(phys_addr_t physaddr)
return 0;
}
+/*
+ * 'key' is typically something like 'wifi_mac0' or 'ether_mac1'. Values are 12
+ * character strings of MAC address digits, in hex.
+ */
+static int vpd_lookup_mac_address(const char *key, u8 *mac)
+{
+ const char *entry;
+ int ret;
+
+ if (!key)
+ return -EINVAL;
+
+ entry = vpd_get_entry(key);
+ if (!entry)
+ return -ENOENT;
+
+ if (strlen(entry) != ETH_ALEN * 2)
+ return -EINVAL;
+
+ ret = hex2bin(mac, entry, ETH_ALEN);
+ if (ret)
+ return ret;
+
+ return 0;
+}
+
+static struct device_mac_addr_provider vpd_mac_addr_provider = {
+ .prefix = "google-vpd",
+ .lookup = &vpd_lookup_mac_address,
+};
+
static int vpd_probe(struct coreboot_device *dev)
{
int ret;
@@ -300,11 +363,15 @@ static int vpd_probe(struct coreboot_device *dev)
return ret;
}
+ device_register_mac_addr_provider(&vpd_mac_addr_provider);
+
return 0;
}
static int vpd_remove(struct coreboot_device *dev)
{
+ device_unregister_mac_addr_provider(&vpd_mac_addr_provider);
+
vpd_section_destroy(&ro_vpd);
vpd_section_destroy(&rw_vpd);
--
2.18.0.865.gffc8e1a3cd6-goog
next prev parent reply other threads:[~2018-08-14 22:38 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 22:37 [RFC PATCH v1 0/3] device property: Support MAC address in VPD Brian Norris
2018-08-14 22:37 ` [RFC PATCH v1 1/3] dt-bindings: net: Add 'mac-address-lookup' property Brian Norris
2018-08-15 20:45 ` Rob Herring
2018-08-14 22:37 ` [RFC PATCH v1 2/3] device property: Support complex MAC address lookup Brian Norris
2018-08-14 22:37 ` Brian Norris [this message]
2018-08-14 23:00 ` [RFC PATCH v1 0/3] device property: Support MAC address in VPD Florian Fainelli
2018-08-15 0:22 ` Brian Norris
2018-08-15 0:52 ` Florian Fainelli
2018-08-15 1:44 ` Brian Norris
2018-08-15 22:07 ` Stephen Boyd
2018-08-31 0:55 ` Brian Norris
2018-08-15 22:16 ` Rob Herring
2018-08-31 1:26 ` Brian Norris
2018-08-31 8:43 ` Srinivas Kandagatla
2018-08-31 21:28 ` Brian Norris
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180814223758.117433-4-briannorris@chromium.org \
--to=computersforpeace@gmail.com \
--cc=andrew@lunn.ch \
--cc=briannorris@chromium.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=f.fainelli@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=jwerner@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=netdev@vger.kernel.org \
--cc=rafael@kernel.org \
--cc=robh+dt@kernel.org \
--cc=swboyd@chromium.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).