From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 27770C46460 for ; Wed, 15 Aug 2018 07:34:59 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id D0E5B21654 for ; Wed, 15 Aug 2018 07:34:58 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org D0E5B21654 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728935AbeHOKZ6 (ORCPT ); Wed, 15 Aug 2018 06:25:58 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:52374 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726014AbeHOKZ6 (ORCPT ); Wed, 15 Aug 2018 06:25:58 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 7146D18A; Wed, 15 Aug 2018 00:34:55 -0700 (PDT) Received: from edgewater-inn.cambridge.arm.com (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 37E153F5BD; Wed, 15 Aug 2018 00:34:55 -0700 (PDT) Received: by edgewater-inn.cambridge.arm.com (Postfix, from userid 1000) id 119341AE0DBE; Wed, 15 Aug 2018 08:35:02 +0100 (BST) Date: Wed, 15 Aug 2018 08:35:01 +0100 From: Will Deacon To: "Yang, Shunyong" Cc: "jean-philippe.brucker@arm.com" , "joro@8bytes.org" , "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" , "thunder.leizhen@huawei.com" , "robin.murphy@arm.com" , "linux-arm-kernel@lists.infradead.org" Subject: Re: [PATCH v3 4/6] iommu/io-pgtable-arm: add support for non-strict mode Message-ID: <20180815073501.GA2375@arm.com> References: <1531376312-2192-5-git-send-email-thunder.leizhen@huawei.com> <89cc2201-99ab-3f3b-a2d1-1766515d4375@arm.com> <5B597628.2020103@huawei.com> <04239cfa-bcf2-a33a-e662-ebc75e66782b@arm.com> <1d24541340334954969c58980ef85444@HXTBJIDCEMVIW01.hxtcorp.net> <5B7293E5.7040702@huawei.com> <20180814083500.GA28101@arm.com> <7a2dedda98aa9e677eb7f85b6b55e34e0128d2d9.camel@hxt-semitech.com> <20180815073300.GA2100@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180815073300.GA2100@arm.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 15, 2018 at 08:33:01AM +0100, Will Deacon wrote: > On Wed, Aug 15, 2018 at 01:43:37AM +0000, Yang, Shunyong wrote: > > On Tue, 2018-08-14 at 11:02 +0100, Robin Murphy wrote: > > > On 14/08/18 09:35, Will Deacon wrote: > > > > On Tue, Aug 14, 2018 at 04:33:41PM +0800, Leizhen (ThunderTown) > > > > wrote: > > > > > On 2018/8/6 9:32, Yang, Shunyong wrote: > > > > > > On 2018/7/26 22:37, Robin Murphy wrote: > > > > > > > Because DMA code is not the only caller of iommu_map/unmap. > > > > > > > It's > > > > > > > perfectly legal in the IOMMU API to partially unmap a > > > > > > > previous mapping > > > > > > > such that a block entry needs to be split. The DMA API, > > > > > > > however, is a > > > > > > > lot more constrined, and thus by construction the iommu-dma > > > > > > > layer will > > > > > > > never generate a block-splitting iommu_unmap() except as a > > > > > > > result of > > > > > > > illegal DMA API usage, and we obviously do not need to > > > > > > > optimise for that > > > > > > > (you will get a warning about mismatched unmaps under dma- > > > > > > > debug, but > > > > > > > it's a bit too expensive to police in the general case). > > > > > > > > > > > > > > > > > > > When I was reading the code around arm_lpae_split_blk_unmap(), > > > > > > I was > > > > > > curious in which scenario a block will be split. Now with your > > > > > > comments > > > > > > "Because DMA code is not the only caller of iommu_map/unmap", > > > > > > it seems > > > > > > depending on the user. > > > > > > > > > > > > Would you please explain this further? I mean besides DMA, > > > > > > which user > > > > > > will use iommu_map/umap and how it split a block. > > > > > > > > > > I also think that arm_lpae_split_blk_unmap() scenario is not > > > > > exist, maybe > > > > > we should remove it, and give a warning for this wrong usage. > > > > > > > > Can't it happen with VFIO? > > > > > > ...or GPU drivers, or anyone else managing their own IOMMU domain > > > directly. A sequence like this is perfectly legal: > > > > > > iommu_map(domain, iova, paddr, SZ_8M, prot); > > > ... > > > iommu_unmap(domain, iova + SZ_1M * 5, SZ_1M * 3); > > > > > > where if iova and paddr happen to be suitably aligned, the map will > > > lay > > > down blocks, and the unmap will then have to split one of them into > > > pages to remove half of it. We don't tear our hair out maintaining > > > split_blk_unmap() for the fun of it :( > > > > Thank you for the GPU example. But for VFIO, I remember all memory will > > be pinned in the early stage of emulator (such as qemu) start. So, > > the split will occur at which operation? Maybe virtio balloon inflate? > > My memory is pretty hazy here, but I was fairly sure that VFIO didn't > always unmap() with the same granularity as it map()'d, at least for > the v1 interface. Either way, split_blk_unmap() was written because it was > necessary at the time, rather than just for fun! > > Will > IMPORTANT NOTICE: The contents of this email and any attachments are > confidential and may also be privileged. If you are not the intended > recipient, please notify the sender immediately and do not disclose the > contents to any other person, use it for any purpose, or store or copy the > information in any medium. Thank you. Urgh, sorry about this threatening disclaimer ^^. Please disregard. Will