From: David Sterba <dsterba@suse.cz>
To: zhong jiang <zhongjiang@huawei.com>
Cc: clm@fb.com, jbacik@fb.com, dsterba@suse.com,
linux-btrfs@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCHv3 0/3] change some function to be void function
Date: Wed, 15 Aug 2018 14:53:40 +0200 [thread overview]
Message-ID: <20180815125340.GN24025@twin.jikos.cz> (raw)
In-Reply-To: <1533736075-8691-1-git-send-email-zhongjiang@huawei.com>
On Wed, Aug 08, 2018 at 09:47:52PM +0800, zhong jiang wrote:
> v3->v2:
> - Repost the patches with detailed changelog.
> v1->v2:
> - Fix v1 issue that forget to return after remove the variable "ret".
>
> zhong jiang (3):
> fs/btrfs/disk-io: change btrfs_destroy_delayed_refs to be void
> function
> fs/btrfs/extent-tree: change btrfs_free_reserved_bytes to be void
> funtion
> fs/btrfs/tree-log: change btrfs_pin_log_trans to be void function
The patches 2 and 3 can be applied, but please update che subject and
put just "btrfs: " there, not the full file path. That we can find in
the diff. The changelogs can be still improved to be clear about callers
vs callees. Please update and resend.
next prev parent reply other threads:[~2018-08-15 12:53 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-08 13:47 [PATCHv3 0/3] change some function to be void function zhong jiang
2018-08-08 13:47 ` [PATCHv3 1/3] fs/btrfs/disk-io: change btrfs_destroy_delayed_refs " zhong jiang
2018-08-15 12:44 ` David Sterba
2018-08-08 13:47 ` [PATCHv3 2/3] fs/btrfs/extent-tree: change btrfs_free_reserved_bytes to be void funtion zhong jiang
2018-08-08 13:47 ` [PATCHv3 3/3] fs/btrfs/tree-log: change btrfs_pin_log_trans to be void function zhong jiang
2018-08-15 12:53 ` David Sterba [this message]
2018-08-15 13:06 ` [PATCHv3 0/3] change some function " zhong jiang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815125340.GN24025@twin.jikos.cz \
--to=dsterba@suse.cz \
--cc=clm@fb.com \
--cc=dsterba@suse.com \
--cc=jbacik@fb.com \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=zhongjiang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).