From: Cornelia Huck <cohuck@redhat.com>
To: Tony Krowiak <akrowiak@linux.vnet.ibm.com>
Cc: linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org,
kvm@vger.kernel.org, freude@de.ibm.com, schwidefsky@de.ibm.com,
heiko.carstens@de.ibm.com, borntraeger@de.ibm.com,
kwankhede@nvidia.com, bjsdjshi@linux.vnet.ibm.com,
pbonzini@redhat.com, alex.williamson@redhat.com,
pmorel@linux.vnet.ibm.com, alifm@linux.vnet.ibm.com,
mjrosato@linux.vnet.ibm.com, jjherne@linux.vnet.ibm.com,
thuth@redhat.com, pasic@linux.vnet.ibm.com, berrange@redhat.com,
fiuczy@linux.vnet.ibm.com, buendgen@de.ibm.com,
frankja@linux.ibm.com, Tony Krowiak <akrowiak@linux.ibm.com>
Subject: Re: [PATCH v9 15/22] s390: vfio-ap: implement mediated device open callback
Date: Wed, 15 Aug 2018 18:08:14 +0200 [thread overview]
Message-ID: <20180815180814.5985e3f0.cohuck@redhat.com> (raw)
In-Reply-To: <1534196899-16987-16-git-send-email-akrowiak@linux.vnet.ibm.com>
On Mon, 13 Aug 2018 17:48:12 -0400
Tony Krowiak <akrowiak@linux.vnet.ibm.com> wrote:
> From: Tony Krowiak <akrowiak@linux.ibm.com>
>
> Implements the open callback on the mediated matrix device.
> The function registers a group notifier to receive notification
> of the VFIO_GROUP_NOTIFY_SET_KVM event. When notified,
> the vfio_ap device driver will get access to the guest's
> kvm structure. The open callback must ensure that only one
> mediated device shall be opened per guest.
>
> Signed-off-by: Tony Krowiak <akrowiak@linux.ibm.com>
> Acked-by: Halil Pasic <pasic@linux.ibm.com>
> Tested-by: Michael Mueller <mimu@linux.ibm.com>
> Tested-by: Farhan Ali <alifm@linux.ibm.com>
> Tested-by: Pierre Morel <pmorel@linux.ibm.com>
> Acked-by: Pierre Morel <pmorel@linux.ibm.com>
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> ---
> drivers/s390/crypto/vfio_ap_ops.c | 174 ++++++++++++++++++++++++++++++++-
> drivers/s390/crypto/vfio_ap_private.h | 2 +
> 2 files changed, 175 insertions(+), 1 deletions(-)
> @@ -602,7 +633,6 @@ static ssize_t matrix_show(struct device *dev, struct device_attribute *attr,
> }
> DEVICE_ATTR_RO(matrix);
>
> -
Nit: whitespace change
> static struct attribute *vfio_ap_mdev_attrs[] = {
> &dev_attr_assign_adapter.attr,
> &dev_attr_unassign_adapter.attr,
(...)
> +/**
> + * vfio_ap_mdev_open_once
> + *
> + * @matrix_mdev: a mediated matrix device
> + *
> + * Return 0 if no other mediated matrix device has been opened for the
> + * KVM guest assigned to @matrix_mdev; otherwise, returns an error.
> + */
> +static int vfio_ap_mdev_open_once(struct ap_matrix_mdev *matrix_mdev,
> + struct kvm *kvm)
You're passing kvm in here, but do not use it.
> +{
> + struct ap_matrix_mdev *m;
> +
> + mutex_lock(&matrix_dev.lock);
> +
> + list_for_each_entry(m, &matrix_dev.mdev_list, list) {
> + if ((m != matrix_mdev) && (m->kvm == matrix_mdev->kvm)) {
If you used it here instead of matrix_mdev->kvm...
> + mutex_unlock(&matrix_dev.lock);
> + return -EPERM;
> + }
> + }
> +
> + mutex_unlock(&matrix_dev.lock);
> +
> + return 0;
> +}
> +
> +static int vfio_ap_mdev_group_notifier(struct notifier_block *nb,
> + unsigned long action, void *data)
> +{
> + int ret;
> + struct ap_matrix_mdev *matrix_mdev;
> +
> + if (action != VFIO_GROUP_NOTIFY_SET_KVM)
> + return NOTIFY_OK;
> +
> + matrix_mdev = container_of(nb, struct ap_matrix_mdev, group_notifier);
> +
> + matrix_mdev->kvm = data;
> + if (data == NULL)
> + return NOTIFY_OK;
> +
> + ret = vfio_ap_mdev_open_once(matrix_mdev, data);
...you could move this up to before overwriting matrix_mdev->kvm and
bailing out when the check failed, which makes more sense to me.
> + if (ret)
> + return ret;
> +
> + ret = kvm_ap_validate_crypto_setup(matrix_mdev->kvm);
> + if (ret)
> + return ret;
It probably makes more sense to return NOTIFY_DONE in the error case
(NOTIFY_BAD does not sound like a good idea as it would stop processing
the notifier chain).
> +
> + vfio_ap_mdev_copy_masks(matrix_mdev);
> +
> + return NOTIFY_OK;
> +}
Otherwise, looks sane.
next prev parent reply other threads:[~2018-08-15 16:08 UTC|newest]
Thread overview: 138+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-13 21:47 [PATCH v9 00/22] guest dedicated crypto adapters Tony Krowiak
2018-08-13 21:47 ` [PATCH v9 01/22] s390/zcrypt: Add ZAPQ inline function Tony Krowiak
2018-08-13 21:47 ` [PATCH v9 02/22] s390/zcrypt: Review inline assembler constraints Tony Krowiak
2018-08-13 21:48 ` [PATCH v9 03/22] s390/zcrypt: Show load of cards and queues in sysfs Tony Krowiak
2018-08-13 21:48 ` [PATCH v9 04/22] s390/zcrypt: Integrate ap_asm.h into include/asm/ap.h Tony Krowiak
2018-08-14 8:43 ` Cornelia Huck
2018-08-17 13:18 ` Tony Krowiak
2018-08-17 13:27 ` Cornelia Huck
2018-08-17 19:09 ` Tony Krowiak
2018-08-13 21:48 ` [PATCH v9 05/22] KVM: s390: vsie: simulate VCPU SIE entry/exit Tony Krowiak
2018-08-14 8:50 ` Cornelia Huck
2018-08-14 12:46 ` Tony Krowiak
2018-08-13 21:48 ` [PATCH v9 06/22] KVM: s390: introduce and use KVM_REQ_VSIE_RESTART Tony Krowiak
2018-08-13 21:48 ` [PATCH v9 07/22] KVM: s390: refactor crypto initialization Tony Krowiak
2018-08-20 16:41 ` David Hildenbrand
2018-08-20 20:33 ` Tony Krowiak
2018-08-20 20:41 ` David Hildenbrand
2018-08-21 13:29 ` Tony Krowiak
2018-08-13 21:48 ` [PATCH v9 08/22] s390: vfio-ap: base implementation of VFIO AP device driver Tony Krowiak
2018-08-14 10:42 ` Cornelia Huck
2018-08-14 23:30 ` Tony Krowiak
2018-08-13 21:48 ` [PATCH v9 09/22] s390: vfio-ap: register matrix device with VFIO mdev framework Tony Krowiak
2018-08-14 11:19 ` Cornelia Huck
2018-08-15 16:51 ` Tony Krowiak
2018-08-16 16:24 ` Tony Krowiak
2018-08-17 8:43 ` Cornelia Huck
2018-08-17 19:02 ` Tony Krowiak
2018-09-06 8:49 ` Pierre Morel
2018-09-10 13:38 ` Tony Krowiak
2018-09-10 21:58 ` Halil Pasic
2018-08-13 21:48 ` [PATCH v9 10/22] s390: vfio-ap: sysfs interfaces to configure adapters Tony Krowiak
2018-08-15 9:52 ` Cornelia Huck
2018-08-15 16:59 ` Tony Krowiak
2018-08-16 7:30 ` Cornelia Huck
2018-08-17 13:23 ` Tony Krowiak
2018-08-13 21:48 ` [PATCH v9 11/22] s390: vfio-ap: sysfs interfaces to configure domains Tony Krowiak
2018-08-15 12:05 ` Cornelia Huck
2018-08-15 17:00 ` Tony Krowiak
2018-08-13 21:48 ` [PATCH v9 12/22] s390: vfio-ap: sysfs interfaces to configure control domains Tony Krowiak
2018-08-20 14:23 ` Cornelia Huck
2018-08-20 16:43 ` Halil Pasic
2018-08-20 17:41 ` Tony Krowiak
2018-08-21 15:25 ` Cornelia Huck
2018-08-21 17:07 ` Tony Krowiak
2018-08-21 23:18 ` Halil Pasic
2018-08-22 9:42 ` Cornelia Huck
2018-08-22 10:43 ` Halil Pasic
2018-08-22 11:03 ` Pierre Morel
2018-08-22 15:11 ` Christian Borntraeger
2018-08-22 15:34 ` Pierre Morel
2018-08-22 15:48 ` Christian Borntraeger
2018-08-22 15:53 ` Pierre Morel
2018-08-22 17:11 ` Halil Pasic
2018-08-22 19:16 ` Tony Krowiak
2018-08-23 9:26 ` Halil Pasic
2018-08-23 10:41 ` Pierre Morel
2018-08-23 10:25 ` Cornelia Huck
2018-08-23 10:43 ` Pierre Morel
2018-08-23 11:31 ` Cornelia Huck
2018-08-23 11:44 ` Pierre Morel
2018-08-23 14:16 ` Tony Krowiak
2018-08-27 8:33 ` Cornelia Huck
2018-08-27 13:47 ` Tony Krowiak
2018-08-27 13:51 ` Cornelia Huck
2018-08-27 15:39 ` Halil Pasic
2018-09-10 13:27 ` Tony Krowiak
2018-08-22 15:18 ` Tony Krowiak
2018-08-22 14:31 ` Tony Krowiak
2018-08-13 21:48 ` [PATCH v9 13/22] s390: vfio-ap: sysfs interface to view matrix mdev matrix Tony Krowiak
2018-08-20 14:08 ` Cornelia Huck
2018-09-12 17:01 ` Tony Krowiak
2018-09-13 9:12 ` Halil Pasic
2018-08-13 21:48 ` [PATCH v9 14/22] KVM: s390: interfaces to clear CRYCB masks Tony Krowiak
2018-08-15 13:10 ` Cornelia Huck
2018-08-15 17:55 ` Tony Krowiak
2018-08-13 21:48 ` [PATCH v9 15/22] s390: vfio-ap: implement mediated device open callback Tony Krowiak
2018-08-15 16:08 ` Cornelia Huck [this message]
2018-08-15 18:21 ` Tony Krowiak
2018-08-13 21:48 ` [PATCH v9 16/22] s390: vfio-ap: implement VFIO_DEVICE_GET_INFO ioctl Tony Krowiak
2018-08-20 14:24 ` Cornelia Huck
2018-08-13 21:48 ` [PATCH v9 17/22] s390: vfio-ap: zeroize the AP queues Tony Krowiak
2018-08-15 16:24 ` Cornelia Huck
2018-08-15 20:36 ` Tony Krowiak
2018-08-17 9:34 ` Cornelia Huck
2018-08-13 21:48 ` [PATCH v9 18/22] s390: vfio-ap: implement VFIO_DEVICE_RESET ioctl Tony Krowiak
2018-08-15 16:38 ` Cornelia Huck
2018-08-15 21:05 ` Tony Krowiak
2018-08-17 9:38 ` Cornelia Huck
2018-08-17 19:03 ` Tony Krowiak
2018-08-13 21:48 ` [PATCH v9 19/22] KVM: s390: Clear Crypto Control Block when using vSIE Tony Krowiak
2018-08-13 21:48 ` [PATCH v9 20/22] KVM: s390: Handling of Cypto control block in VSIE Tony Krowiak
2018-08-21 8:30 ` David Hildenbrand
2018-08-13 21:48 ` [PATCH v9 21/22] KVM: s390: CPU model support for AP virtualization Tony Krowiak
2018-08-20 14:26 ` Cornelia Huck
2018-08-21 8:03 ` David Hildenbrand
2018-08-22 11:19 ` David Hildenbrand
2018-08-22 11:24 ` David Hildenbrand
2018-08-22 20:16 ` Tony Krowiak
2018-08-23 7:44 ` David Hildenbrand
2018-08-23 10:00 ` Halil Pasic
2018-08-23 10:28 ` David Hildenbrand
2018-08-23 11:10 ` Pierre Morel
2018-08-23 11:12 ` David Hildenbrand
2018-08-23 12:47 ` Pierre Morel
2018-08-23 13:22 ` Halil Pasic
2018-08-23 13:38 ` David Hildenbrand
2018-08-23 14:59 ` Pierre Morel
2018-08-23 17:35 ` Tony Krowiak
2018-08-23 17:40 ` David Hildenbrand
2018-08-24 10:28 ` Halil Pasic
2018-08-22 14:33 ` Pierre Morel
2018-08-22 15:04 ` David Hildenbrand
2018-08-22 15:50 ` Pierre Morel
2018-08-22 16:57 ` David Hildenbrand
2018-08-22 21:05 ` Tony Krowiak
2018-08-23 7:42 ` David Hildenbrand
2018-08-22 20:54 ` Tony Krowiak
2018-08-23 7:48 ` David Hildenbrand
2018-08-23 8:24 ` Cornelia Huck
2018-09-12 17:42 ` Tony Krowiak
2018-09-17 7:57 ` David Hildenbrand
2018-08-23 8:26 ` Pierre Morel
2018-08-13 21:48 ` [PATCH v9 22/22] s390: doc: detailed specifications " Tony Krowiak
2018-08-20 16:03 ` Cornelia Huck
2018-08-20 20:16 ` Tony Krowiak
2018-08-21 16:13 ` Cornelia Huck
2018-08-21 19:21 ` Tony Krowiak
2018-08-21 18:54 ` Halil Pasic
2018-08-22 7:38 ` Cornelia Huck
2018-08-21 9:00 ` Harald Freudenberger
2018-08-21 15:53 ` Cornelia Huck
2018-08-22 7:04 ` Harald Freudenberger
2018-08-22 10:09 ` Cornelia Huck
2018-08-22 10:13 ` Harald Freudenberger
2018-08-22 10:45 ` Halil Pasic
2018-08-22 10:19 ` [PATCH v9 00/22] guest dedicated crypto adapters Cornelia Huck
2018-08-22 10:58 ` Pierre Morel
2018-08-22 18:59 ` Tony Krowiak
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180815180814.5985e3f0.cohuck@redhat.com \
--to=cohuck@redhat.com \
--cc=akrowiak@linux.ibm.com \
--cc=akrowiak@linux.vnet.ibm.com \
--cc=alex.williamson@redhat.com \
--cc=alifm@linux.vnet.ibm.com \
--cc=berrange@redhat.com \
--cc=bjsdjshi@linux.vnet.ibm.com \
--cc=borntraeger@de.ibm.com \
--cc=buendgen@de.ibm.com \
--cc=fiuczy@linux.vnet.ibm.com \
--cc=frankja@linux.ibm.com \
--cc=freude@de.ibm.com \
--cc=heiko.carstens@de.ibm.com \
--cc=jjherne@linux.vnet.ibm.com \
--cc=kvm@vger.kernel.org \
--cc=kwankhede@nvidia.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-s390@vger.kernel.org \
--cc=mjrosato@linux.vnet.ibm.com \
--cc=pasic@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=pmorel@linux.vnet.ibm.com \
--cc=schwidefsky@de.ibm.com \
--cc=thuth@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).