archive mirror
 help / color / mirror / Atom feed
From: Lyude Paul <>
Cc:, Lukas Wunner <>,
	Ben Skeggs <>, David Airlie <>,,
Subject: [PATCH v8 2/5] drm/nouveau: Remove duplicate poll_enable() in pmops_runtime_suspend()
Date: Wed, 15 Aug 2018 15:00:12 -0400	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

Since actual hotplug notifications don't get disabled until
nouveau_display_fini() is called, all this will do is cause any hotplugs
that happen between this drm_kms_helper_poll_disable() call and the
actual hotplug disablement to potentially be dropped if ACPI isn't
around to help us.

Signed-off-by: Lyude Paul <>
Acked-by: Karol Herbst <>
Acked-by: Daniel Vetter <>
Cc: Lukas Wunner <>
 drivers/gpu/drm/nouveau/nouveau_drm.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/gpu/drm/nouveau/nouveau_drm.c b/drivers/gpu/drm/nouveau/nouveau_drm.c
index c7ec86d6c3c9..5fdc1fbe2ee5 100644
--- a/drivers/gpu/drm/nouveau/nouveau_drm.c
+++ b/drivers/gpu/drm/nouveau/nouveau_drm.c
@@ -835,7 +835,6 @@ nouveau_pmops_runtime_suspend(struct device *dev)
 		return -EBUSY;
-	drm_kms_helper_poll_disable(drm_dev);
 	ret = nouveau_do_suspend(drm_dev, true);

  parent reply	other threads:[~2018-08-15 19:00 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-15 19:00 [PATCH v8 0/5] Fix connector probing deadlocks from RPM bugs Lyude Paul
2018-08-15 19:00 ` [PATCH v8 1/5] drm/nouveau: Fix bogus drm_kms_helper_poll_enable() placement Lyude Paul
2018-08-15 19:00 ` Lyude Paul [this message]
2018-08-15 19:00 ` [PATCH v8 3/5] drm/nouveau: Fix deadlock with fb_helper with async RPM requests Lyude Paul
2018-08-15 19:00 ` [PATCH v8 4/5] drm/nouveau: Use pm_runtime_get_noresume() in connector_detect() Lyude Paul
2018-08-15 19:00 ` [PATCH v8 5/5] drm/nouveau: Fix deadlocks in nouveau_connector_detect() Lyude Paul

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).