From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 434DFC4321D for ; Thu, 16 Aug 2018 08:03:54 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EE0F42147D for ; Thu, 16 Aug 2018 08:03:53 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org EE0F42147D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389771AbeHPLAe (ORCPT ); Thu, 16 Aug 2018 07:00:34 -0400 Received: from mx3-rdu2.redhat.com ([66.187.233.73]:35796 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1726321AbeHPLAe (ORCPT ); Thu, 16 Aug 2018 07:00:34 -0400 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4AB05819703A; Thu, 16 Aug 2018 08:03:50 +0000 (UTC) Received: from dhcp-128-65.nay.redhat.com (ovpn-12-131.pek2.redhat.com [10.72.12.131]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 4A0612166BA5; Thu, 16 Aug 2018 08:03:37 +0000 (UTC) Date: Thu, 16 Aug 2018 16:02:59 +0800 From: Dave Young To: Yannik Sembritzki Cc: Linus Torvalds , David Howells , Thomas Gleixner , Ingo Molnar , Peter Anvin , the arch/x86 maintainers , Linux Kernel Mailing List , Baoquan He , Justin Forbes , Peter Jones , Greg Kroah-Hartman , James Bottomley , Matthew Garrett , Vivek Goyal Subject: Re: [PATCH 2/2] [FIXED v2] Replace magic for trusting the secondary keyring with #define Message-ID: <20180816080259.GA6241@dhcp-128-65.nay.redhat.com> References: <20180815194244.29564-3-yannik@sembritzki.me> <201808160443.5h16PxVs%fengguang.wu@intel.com> <1bfa03ed-c9f8-d0f2-700c-c93e96d5b99c@sembritzki.me> <20180816011106.GC5915@dhcp-128-65.nay.redhat.com> <7834c175-7480-d5bd-d964-a4dd783af1f3@sembritzki.me> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <7834c175-7480-d5bd-d964-a4dd783af1f3@sembritzki.me> User-Agent: Mutt/1.9.5 (2018-04-13) X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 16 Aug 2018 08:03:50 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.8]); Thu, 16 Aug 2018 08:03:50 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'dyoung@redhat.com' RCPT:'' Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 08/16/18 at 09:43am, Yannik Sembritzki wrote: > On 16.08.2018 03:11, Dave Young wrote: > > Instead of fix your 1st patch in 2nd patch, I would suggest to > > switch the patch order. In 1st patch change the common code to use > > the new macro and in 2nd patch you can directly fix the kexec code > > with TRUST_SECONDARY_KEYRING. > My reasoning for doing it in this order was that the first patch which > fixes the bug itself should be merged into stable, while the refactoring > doesn't necessarily have to. I'm not familiar with the linux development > process, so please correct me if this should be done in another fashion. Frankly I'm not sure about the stable process. But personally I do not like the order. Cced Greg for opinions about stable concern. > > Yannik