From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 68394C4321D for ; Thu, 16 Aug 2018 16:49:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 2DB1720C07 for ; Thu, 16 Aug 2018 16:49:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2DB1720C07 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=goodmis.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729920AbeHPTs6 (ORCPT ); Thu, 16 Aug 2018 15:48:58 -0400 Received: from mail.kernel.org ([198.145.29.99]:54908 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727247AbeHPTs5 (ORCPT ); Thu, 16 Aug 2018 15:48:57 -0400 Received: from gandalf.local.home (cpe-66-24-56-78.stny.res.rr.com [66.24.56.78]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id B1C4F20C0D; Thu, 16 Aug 2018 16:49:18 +0000 (UTC) Date: Thu, 16 Aug 2018 12:49:17 -0400 From: Steven Rostedt To: Masami Hiramatsu Cc: Ingo Molnar , linux-kernel@vger.kernel.org, Jens Axboe , linux-block@vger.kernel.org Subject: Re: [PATCH 2/2] tracing/blktrace: Fix to allow setting same value Message-ID: <20180816124917.77c82f04@gandalf.local.home> In-Reply-To: <20180817013847.85ff26224bfd48d0fca1fd3f@kernel.org> References: <153441301698.6024.1680500212551396320.stgit@devbox> <153441307534.6024.2684721209411781531.stgit@devbox> <20180816103802.08678002@gandalf.local.home> <20180817013847.85ff26224bfd48d0fca1fd3f@kernel.org> X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; x86_64-pc-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 17 Aug 2018 01:38:47 +0900 Masami Hiramatsu wrote: > On Thu, 16 Aug 2018 10:38:02 -0400 > Steven Rostedt wrote: > > > On Thu, 16 Aug 2018 18:51:15 +0900 > > Masami Hiramatsu wrote: > > > > > Current trace-enable attribute in sysfs returns an error > > > if user writes the same setting value as current one, > > > e.g. > > > > > > # cat /sys/block/sda/trace/enable > > > 0 > > > # echo 0 > /sys/block/sda/trace/enable > > > bash: echo: write error: Invalid argument > > > # echo 1 > /sys/block/sda/trace/enable > > > # echo 1 > /sys/block/sda/trace/enable > > > bash: echo: write error: Device or resource busy > > > > > > But this is not a preferred behavior, it should ignore > > > if new setting is same as current one. This fixes the > > > problem as below. > > > > > > # cat /sys/block/sda/trace/enable > > > 0 > > > # echo 0 > /sys/block/sda/trace/enable > > > # echo 1 > /sys/block/sda/trace/enable > > > # echo 1 > /sys/block/sda/trace/enable > > > > > > Signed-off-by: Masami Hiramatsu > > > Cc: Jens Axboe > > > Cc: linux-block@vger.kernel.org > > > --- > > > kernel/trace/blktrace.c | 11 +++++++---- > > > 1 file changed, 7 insertions(+), 4 deletions(-) > > > > > > diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c > > > index 987d9a9ae283..e67db1e8a000 100644 > > > --- a/kernel/trace/blktrace.c > > > +++ b/kernel/trace/blktrace.c > > > @@ -1602,11 +1602,11 @@ static int blk_trace_remove_queue(struct request_queue *q) > > > struct blk_trace *bt; > > > > > > bt = xchg(&q->blk_trace, NULL); > > > - if (bt == NULL) > > > - return -EINVAL; > > > + if (bt != NULL) { > > > + put_probe_ref(); > > > + blk_trace_free(bt); > > > + } > > > > > > - put_probe_ref(); > > > - blk_trace_free(bt); > > > return 0; > > > } > > > > > > @@ -1619,6 +1619,9 @@ static int blk_trace_setup_queue(struct request_queue *q, > > > struct blk_trace *bt = NULL; > > > int ret = -ENOMEM; > > > > > > + if (q->blk_trace) > > > + return 0; > > > + > > > bt = kzalloc(sizeof(*bt), GFP_KERNEL); > > > if (!bt) > > > return -ENOMEM; > > > > Hmm, why not just do this? Does this fix it too? > > Ah, yes, but we need to clear "ret" in that case. Sure. > > Thanks! > > > > > diff --git a/kernel/trace/blktrace.c b/kernel/trace/blktrace.c > > index 987d9a9ae283..10b2b9c5fd25 100644 > > --- a/kernel/trace/blktrace.c > > +++ b/kernel/trace/blktrace.c > > @@ -1841,6 +1841,8 @@ static ssize_t sysfs_blk_trace_attr_store(struct device *dev, > > mutex_lock(&q->blk_trace_mutex); > > > > if (attr == &dev_attr_enable) { > > + if (!!value == !!q->blk_trace) { + ret = 0; > > + goto out_unlock_bdev; + } -- Steve > > if (value) > > ret = blk_trace_setup_queue(q, bdev); > > else > > > > -- Steve > >