linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Bjorn Helgaas <helgaas@kernel.org>, linux-pci@vger.kernel.org
Cc: Hari Vyas <hari.vyas@broadcom.com>,
	Ray Jui <ray.jui@broadcom.com>,
	Srinath Mannam <srinath.mannam@broadcom.com>,
	Guenter Roeck <linux@roeck-us.net>, Jens Axboe <axboe@kernel.dk>,
	Lukas Wunner <lukas@wunner.de>,
	Konstantin Khlebnikov <khlebnikov@yandex-team.ru>,
	Marta Rybczynska <mrybczyn@kalray.eu>,
	Pierre-Yves Kerbrat <pkerbrat@kalray.eu>,
	linux-kernel@vger.kernel.org
Subject: [RFC PATCH 0/6] pci: Rework is_added race fix and address bridge enable races
Date: Fri, 17 Aug 2018 14:48:56 +1000	[thread overview]
Message-ID: <20180817044902.31420-1-benh@kernel.crashing.org> (raw)

This is really two series but since they conflict a bit separately
here they are in one:

First we undo the mess of those atomic priv_flags. The atomicity
doesn't provide any security since there's no locking against
the other state pertaining to those flags, it only protects the
flags themselves.

The is_added mess is fixed much more simply by moving the assignment
of the flag to before we start the driver. This is in line with the
rest of the PCI code: until bound to the device model, we are essentially
assuming a single threaded environment. is_added is a flag that is
logically owned by that part of the PCI code, and thus should be set
and cleared within that "safer" environment.

This removes the horrid relative includes in the powerpc code as well.

The second part aims at fixing the enable/disable/set_master races,
and does so by providing a framework for future device state locking
issues.

It introduces a pci_dev->state_mutex which is used at a lower level
than the device_lock (the device lock isn't suitable, as explained
in the cset comments) and uses it to protect enablement and set_master.



             reply	other threads:[~2018-08-17  4:49 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-17  4:48 Benjamin Herrenschmidt [this message]
2018-08-17  4:48 ` [RFC PATCH 1/6] Revert "PCI: Fix is_added/is_busmaster race condition" Benjamin Herrenschmidt
2018-08-17  4:57   ` Benjamin Herrenschmidt
2018-08-17 15:44   ` Bjorn Helgaas
2018-08-18  3:24     ` Benjamin Herrenschmidt
2018-08-19  2:24       ` Bjorn Helgaas
2018-08-20  2:10         ` Benjamin Herrenschmidt
2018-08-20  6:25           ` Hari Vyas
2018-08-20 11:09             ` Benjamin Herrenschmidt
2018-08-20 11:43               ` Hari Vyas
2018-08-20  7:17           ` Lukas Wunner
2018-08-20 11:12             ` Benjamin Herrenschmidt
2018-08-17  4:48 ` [RFC PATCH 2/6] pci: Set pci_dev->is_added before calling device_add Benjamin Herrenschmidt
2018-08-17  4:57   ` Benjamin Herrenschmidt
2018-08-17 16:25   ` Bjorn Helgaas
2018-08-17 18:15     ` Lukas Wunner
2018-08-18  3:41       ` Benjamin Herrenschmidt
2018-08-18  3:28     ` Benjamin Herrenschmidt
2018-08-17  4:48 ` [RFC PATCH 3/6] pci: Remove priv_flags and use dev->error_state for "disconnected" status Benjamin Herrenschmidt
2018-08-17  5:13   ` [RFC PATCH v2 " Benjamin Herrenschmidt
2018-08-17  4:49 ` [RFC PATCH 4/6] pci: Add a mutex to pci_dev to protect device state Benjamin Herrenschmidt
2018-08-17  4:49 ` [RFC PATCH 5/6] pci: Protect the enable/disable state of pci_dev using the state mutex Benjamin Herrenschmidt
2018-08-17  8:09   ` Marta Rybczynska
2018-08-17  8:30     ` Benjamin Herrenschmidt
2018-08-17  9:00       ` Hari Vyas
2018-08-17  9:39         ` Benjamin Herrenschmidt
2018-08-17 10:10           ` Hari Vyas
2018-08-17 10:24             ` Benjamin Herrenschmidt
2018-08-17  4:49 ` [RFC PATCH 6/6] pci: Protect is_busmaster using the state lock Benjamin Herrenschmidt
2018-08-17  5:03 ` [RFC PATCH 0/6] pci: Rework is_added race fix and address bridge enable races Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180817044902.31420-1-benh@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=axboe@kernel.dk \
    --cc=hari.vyas@broadcom.com \
    --cc=helgaas@kernel.org \
    --cc=khlebnikov@yandex-team.ru \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=lukas@wunner.de \
    --cc=mrybczyn@kalray.eu \
    --cc=pkerbrat@kalray.eu \
    --cc=ray.jui@broadcom.com \
    --cc=srinath.mannam@broadcom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).