From: "hch@lst.de" <hch@lst.de>
To: Bart Van Assche <Bart.VanAssche@wdc.com>
Cc: "hare@suse.de" <hare@suse.de>,
"axboe@kernel.dk" <axboe@kernel.dk>, "hch@lst.de" <hch@lst.de>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"keith.busch@intel.com" <keith.busch@intel.com>,
"linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>,
"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>,
"hare@suse.com" <hare@suse.com>,
"sagi@grimberg.me" <sagi@grimberg.me>
Subject: Re: [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups
Date: Fri, 17 Aug 2018 09:00:13 +0200 [thread overview]
Message-ID: <20180817070013.GD11170@lst.de> (raw)
In-Reply-To: <f9ad4ed4685e51a7b0378f11d3ce9d0a76235095.camel@wdc.com>
On Tue, Aug 14, 2018 at 03:44:57PM +0000, Bart Van Assche wrote:
> On Tue, 2018-08-14 at 17:39 +0200, Hannes Reinecke wrote:
> > While I have considered having nvme_nvm_register_sysfs() returning a
> > pointer I would then have to remove the 'static' declaration from the
> > nvm_dev_attr_group_12/20.
> > Which I didn't really like, either.
>
> Hmm ... I don't see why the static declaration would have to be removed from
> nvm_dev_attr_group_12/20 if nvme_nvm_register_sysfs() would return a pointer?
> Am I perhaps missing something?
No, I think that would be the preferable approach IFF patching the global
table of groups would be viable. I don't think it is, though - we can
have both normal NVMe and LightNVM devices in the same system, so we
can't just patch it over.
So we'll need three different attribut group arrays:
const struct attribute_group *nvme_ns_id_attr_groups[] = {
&nvme_ns_id_attr_group,
NULL,
};
const struct attribute_group *lightnvm12_ns_id_attr_groups[] = {
&nvme_ns_id_attr_group,
&nvm_dev_attr_group_12,
NULL,
};
const struct attribute_group *lightnvm20_ns_id_attr_groups[] = {
&nvme_ns_id_attr_group,
&nvm_dev_attr_group_20,
NULL,
};
and a function to select which one to use.
next prev parent reply other threads:[~2018-08-17 6:59 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-14 7:33 [PATCHv2 0/5] genhd: register default groups with device_add_disk() Hannes Reinecke
2018-08-14 7:33 ` [PATCH 1/5] block: genhd: add 'groups' argument to device_add_disk Hannes Reinecke
2018-08-14 15:17 ` Bart Van Assche
2018-08-14 7:33 ` [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups Hannes Reinecke
2018-08-14 9:03 ` Javier González
2018-08-14 9:59 ` Matias Bjørling
2018-08-14 15:20 ` Bart Van Assche
2018-08-14 15:39 ` Hannes Reinecke
2018-08-14 15:44 ` Bart Van Assche
2018-08-17 7:00 ` hch [this message]
2018-08-17 7:53 ` Hannes Reinecke
2018-08-17 20:04 ` Bart Van Assche
2018-08-17 22:47 ` Sagi Grimberg
2018-08-20 6:34 ` Hannes Reinecke
2018-08-14 21:53 ` kbuild test robot
2018-08-14 21:53 ` [RFC PATCH] nvme: nvme_ns_id_attr_group can be static kbuild test robot
2018-08-17 6:55 ` [PATCH 2/5] nvme: register ns_id attributes as default sysfs groups Christoph Hellwig
2018-08-14 7:33 ` [PATCH 3/5] aoe: use device_add_disk_with_groups() Hannes Reinecke
2018-08-14 15:21 ` Bart Van Assche
2018-08-17 6:53 ` Christoph Hellwig
2018-08-14 7:33 ` [PATCH 4/5] zram: register default groups with device_add_disk() Hannes Reinecke
2018-08-14 15:23 ` Bart Van Assche
2018-08-14 7:33 ` [PATCH 5/5] virtio-blk: modernize sysfs attribute creation Hannes Reinecke
2018-08-14 15:24 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817070013.GD11170@lst.de \
--to=hch@lst.de \
--cc=Bart.VanAssche@wdc.com \
--cc=axboe@kernel.dk \
--cc=hare@suse.com \
--cc=hare@suse.de \
--cc=keith.busch@intel.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).