linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] arm: dts: am4372: setup rtc as system-power-controller
@ 2018-07-25  5:55 Keerthy
  2018-08-08  9:06 ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Keerthy @ 2018-07-25  5:55 UTC (permalink / raw)
  To: tony; +Cc: t-kristo, j-keerthy, linux-omap, linux-kernel, devicetree

RTC alarm2 is connected to pmic_en line and hence can be used to control
the pmic enabling/disabling. Hence add the system-power-controller for rtc
node.

Signed-off-by: Keerthy <j-keerthy@ti.com>
---
 arch/arm/boot/dts/am4372.dtsi | 1 +
 1 file changed, 1 insertion(+)

diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
index f0cbd86..d4b7c59 100644
--- a/arch/arm/boot/dts/am4372.dtsi
+++ b/arch/arm/boot/dts/am4372.dtsi
@@ -469,6 +469,7 @@
 			ti,hwmods = "rtc";
 			clocks = <&clk_32768_ck>;
 			clock-names = "int-clk";
+			system-power-controller;
 			status = "disabled";
 		};
 
-- 
1.9.1


^ permalink raw reply related	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm: dts: am4372: setup rtc as system-power-controller
  2018-07-25  5:55 [PATCH] arm: dts: am4372: setup rtc as system-power-controller Keerthy
@ 2018-08-08  9:06 ` Tony Lindgren
  2018-08-08  9:08   ` Keerthy
  0 siblings, 1 reply; 4+ messages in thread
From: Tony Lindgren @ 2018-08-08  9:06 UTC (permalink / raw)
  To: Keerthy; +Cc: t-kristo, linux-omap, linux-kernel, devicetree

* Keerthy <j-keerthy@ti.com> [180725 05:59]:
> RTC alarm2 is connected to pmic_en line and hence can be used to control
> the pmic enabling/disabling. Hence add the system-power-controller for rtc
> node.
> 
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
>  arch/arm/boot/dts/am4372.dtsi | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> index f0cbd86..d4b7c59 100644
> --- a/arch/arm/boot/dts/am4372.dtsi
> +++ b/arch/arm/boot/dts/am4372.dtsi
> @@ -469,6 +469,7 @@
>  			ti,hwmods = "rtc";
>  			clocks = <&clk_32768_ck>;
>  			clock-names = "int-clk";
> +			system-power-controller;
>  			status = "disabled";
>  		};
>  

Should this be queued as a fix for v4.19-rc series?

Regards,

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm: dts: am4372: setup rtc as system-power-controller
  2018-08-08  9:06 ` Tony Lindgren
@ 2018-08-08  9:08   ` Keerthy
  2018-08-17 14:28     ` Tony Lindgren
  0 siblings, 1 reply; 4+ messages in thread
From: Keerthy @ 2018-08-08  9:08 UTC (permalink / raw)
  To: Tony Lindgren; +Cc: t-kristo, linux-omap, linux-kernel, devicetree



On Wednesday 08 August 2018 02:36 PM, Tony Lindgren wrote:
> * Keerthy <j-keerthy@ti.com> [180725 05:59]:
>> RTC alarm2 is connected to pmic_en line and hence can be used to control
>> the pmic enabling/disabling. Hence add the system-power-controller for rtc
>> node.
>>
>> Signed-off-by: Keerthy <j-keerthy@ti.com>
>> ---
>>  arch/arm/boot/dts/am4372.dtsi | 1 +
>>  1 file changed, 1 insertion(+)
>>
>> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
>> index f0cbd86..d4b7c59 100644
>> --- a/arch/arm/boot/dts/am4372.dtsi
>> +++ b/arch/arm/boot/dts/am4372.dtsi
>> @@ -469,6 +469,7 @@
>>  			ti,hwmods = "rtc";
>>  			clocks = <&clk_32768_ck>;
>>  			clock-names = "int-clk";
>> +			system-power-controller;
>>  			status = "disabled";
>>  		};
>>  
> 
> Should this be queued as a fix for v4.19-rc series?

Yes this makes pmic to shutdown during power off.

> 
> Regards,
> 
> Tony
> 

^ permalink raw reply	[flat|nested] 4+ messages in thread

* Re: [PATCH] arm: dts: am4372: setup rtc as system-power-controller
  2018-08-08  9:08   ` Keerthy
@ 2018-08-17 14:28     ` Tony Lindgren
  0 siblings, 0 replies; 4+ messages in thread
From: Tony Lindgren @ 2018-08-17 14:28 UTC (permalink / raw)
  To: Keerthy; +Cc: t-kristo, linux-omap, linux-kernel, devicetree

* Keerthy <j-keerthy@ti.com> [180808 09:11]:
> 
> 
> On Wednesday 08 August 2018 02:36 PM, Tony Lindgren wrote:
> > * Keerthy <j-keerthy@ti.com> [180725 05:59]:
> >> RTC alarm2 is connected to pmic_en line and hence can be used to control
> >> the pmic enabling/disabling. Hence add the system-power-controller for rtc
> >> node.
> >>
> >> Signed-off-by: Keerthy <j-keerthy@ti.com>
> >> ---
> >>  arch/arm/boot/dts/am4372.dtsi | 1 +
> >>  1 file changed, 1 insertion(+)
> >>
> >> diff --git a/arch/arm/boot/dts/am4372.dtsi b/arch/arm/boot/dts/am4372.dtsi
> >> index f0cbd86..d4b7c59 100644
> >> --- a/arch/arm/boot/dts/am4372.dtsi
> >> +++ b/arch/arm/boot/dts/am4372.dtsi
> >> @@ -469,6 +469,7 @@
> >>  			ti,hwmods = "rtc";
> >>  			clocks = <&clk_32768_ck>;
> >>  			clock-names = "int-clk";
> >> +			system-power-controller;
> >>  			status = "disabled";
> >>  		};
> >>  
> > 
> > Should this be queued as a fix for v4.19-rc series?
> 
> Yes this makes pmic to shutdown during power off.

OK thanks applying into omap-for-v4.19/fixes.

Tony

^ permalink raw reply	[flat|nested] 4+ messages in thread

end of thread, other threads:[~2018-08-17 14:28 UTC | newest]

Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-25  5:55 [PATCH] arm: dts: am4372: setup rtc as system-power-controller Keerthy
2018-08-08  9:06 ` Tony Lindgren
2018-08-08  9:08   ` Keerthy
2018-08-17 14:28     ` Tony Lindgren

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).