From: Rob Herring <robh@kernel.org>
To: Paul Cercueil <paul@crapouillou.net>
Cc: Linus Walleij <linus.walleij@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org,
Paul Cercueil <paul@crapouillou.net>
Subject: Re: [PATCH 3/7] pinctrl: ingenic: Merge GPIO functionality
Date: Fri, 17 Aug 2018 09:09:55 -0600 [thread overview]
Message-ID: <20180817150955.GC20845@rob-hp-laptop> (raw)
In-Reply-To: <20180816163544.9072-3-paul@crapouillou.net>
Hi, this email is from Rob's (experimental) review bot. I found a couple
of common problems with your patch. Please see below.
On Thu, 16 Aug 2018 18:35:40 +0200, Paul Cercueil wrote:
> Merge the code of the gpio-ingenic driver into the pinctrl-ingenic
> driver.
>
> The reason behind this, is that the same hardware block handles both pin
> config / muxing and GPIO.
>
> Signed-off-by: Paul Cercueil <paul@crapouillou.net>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
> ---
> .../bindings/pinctrl/ingenic,pinctrl.txt | 38 ++-
> drivers/pinctrl/Kconfig | 2 +
> drivers/pinctrl/pinctrl-ingenic.c | 337 ++++++++++++++++++++-
> 3 files changed, 365 insertions(+), 12 deletions(-)
>
DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.
next prev parent reply other threads:[~2018-08-17 15:10 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-16 16:35 [PATCH 1/7] pinctrl: ingenic: Probe driver at subsys_initcall Paul Cercueil
2018-08-16 16:35 ` [PATCH 2/7] pinctrl: ingenic: Mark probe function as __init Paul Cercueil
2018-08-16 16:35 ` [PATCH 3/7] pinctrl: ingenic: Merge GPIO functionality Paul Cercueil
2018-08-17 15:09 ` Rob Herring [this message]
2018-08-16 16:35 ` [PATCH 4/7] pinctrl: ingenic: Implement .get_direction for GPIO chips Paul Cercueil
2018-08-16 16:35 ` [PATCH 5/7] pinctrl: ingenic: Add support for the JZ4725B Paul Cercueil
2018-08-17 15:09 ` Rob Herring
2018-08-16 16:35 ` [PATCH 6/7] pinctrl: ingenic: Drop dependency on MACH_INGENIC Paul Cercueil
2018-08-16 16:35 ` [PATCH 7/7] gpio: ingenic: Remove driver Paul Cercueil
2018-08-17 15:09 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817150955.GC20845@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=paul@crapouillou.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).