From: Rob Herring <robh@kernel.org>
To: David Bauer <mail@david-bauer.net>
Cc: David Bauer <mail@david-bauer.net>,
Linus Walleij <linus.walleij@linaro.org>,
Mark Rutland <mark.rutland@arm.com>,
linux-gpio@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] gpio: 74x164: add lines-initial-states property
Date: Fri, 17 Aug 2018 09:10:05 -0600 [thread overview]
Message-ID: <20180817151005.GG20845@rob-hp-laptop> (raw)
In-Reply-To: <20180815201855.29738-1-mail@david-bauer.net>
Hi, this email is from Rob's (experimental) review bot. I found a couple
of common problems with your patch. Please see below.
On Wed, 15 Aug 2018 22:18:54 +0200, David Bauer wrote:
> This adds the ability to define the initial state of each output line on
> device probe.
>
> Signed-off-by: David Bauer <mail@david-bauer.net>
The preferred subject prefix is "dt-bindings: <binding dir>: ...".
> ---
> Documentation/devicetree/bindings/gpio/gpio-74x164.txt | 5 +++++
> drivers/gpio/gpio-74x164.c | 3 +++
> 2 files changed, 8 insertions(+)
>
DT bindings (including binding headers) should be a separate patch. See
Documentation/devicetree/bindings/submitting-patches.txt.
prev parent reply other threads:[~2018-08-17 15:10 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-15 20:18 [PATCH] gpio: 74x164: add lines-initial-states property David Bauer
2018-08-16 8:11 ` Linus Walleij
2018-08-19 23:55 ` David Bauer
2018-08-17 15:10 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180817151005.GG20845@rob-hp-laptop \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mail@david-bauer.net \
--cc=mark.rutland@arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).