* [PATCH] kernel: Add spaces around '=' operator
@ 2018-08-17 13:23 Bhaskar Singh
2018-08-17 16:19 ` Greg KH
0 siblings, 1 reply; 2+ messages in thread
From: Bhaskar Singh @ 2018-08-17 13:23 UTC (permalink / raw)
To: mark.rutland; +Cc: gregkh, linux-kernel, mingo, bhaskar.kernel
This patch fixes the checkpatch.pl ERROR:
ERROR: spaces required around that '==' (ctx:VxV)
Signed-off-by: Bhaskar Singh <bhaskar.kernel@gmail.com>
---
kernel/acct.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/kernel/acct.c b/kernel/acct.c
index addf7732fb56..6dc0a55b575c 100644
--- a/kernel/acct.c
+++ b/kernel/acct.c
@@ -449,7 +449,7 @@ static void fill_ac(acct_t *ac)
#endif
do_div(elapsed, AHZ);
ac->ac_btime = get_seconds() - elapsed;
-#if ACCT_VERSION==2
+#if ACCT_VERSION == 2
ac->ac_ahz = AHZ;
#endif
--
2.16.4
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] kernel: Add spaces around '=' operator
2018-08-17 13:23 [PATCH] kernel: Add spaces around '=' operator Bhaskar Singh
@ 2018-08-17 16:19 ` Greg KH
0 siblings, 0 replies; 2+ messages in thread
From: Greg KH @ 2018-08-17 16:19 UTC (permalink / raw)
To: Bhaskar Singh; +Cc: mark.rutland, linux-kernel, mingo
On Fri, Aug 17, 2018 at 06:53:48PM +0530, Bhaskar Singh wrote:
> This patch fixes the checkpatch.pl ERROR:
>
> ERROR: spaces required around that '==' (ctx:VxV)
>
> Signed-off-by: Bhaskar Singh <bhaskar.kernel@gmail.com>
> ---
> kernel/acct.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/kernel/acct.c b/kernel/acct.c
> index addf7732fb56..6dc0a55b575c 100644
> --- a/kernel/acct.c
> +++ b/kernel/acct.c
> @@ -449,7 +449,7 @@ static void fill_ac(acct_t *ac)
> #endif
> do_div(elapsed, AHZ);
> ac->ac_btime = get_seconds() - elapsed;
> -#if ACCT_VERSION==2
> +#if ACCT_VERSION == 2
checkpatch is a guide, not a fast rule, and might not matter here.
Please stick to checkpatch fixes in drivers/staging/ only, not any other
part of the kernel unless you know the maintainer accepts such patches.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-17 16:19 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-17 13:23 [PATCH] kernel: Add spaces around '=' operator Bhaskar Singh
2018-08-17 16:19 ` Greg KH
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).