From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.5 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2EFEAC4321D for ; Fri, 17 Aug 2018 16:51:23 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E1C0021A2D for ; Fri, 17 Aug 2018 16:51:22 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org E1C0021A2D Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=stgolabs.net Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727969AbeHQTz0 (ORCPT ); Fri, 17 Aug 2018 15:55:26 -0400 Received: from mx2.suse.de ([195.135.220.15]:50580 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727218AbeHQTz0 (ORCPT ); Fri, 17 Aug 2018 15:55:26 -0400 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 26EF1ADBB; Fri, 17 Aug 2018 16:51:19 +0000 (UTC) Date: Fri, 17 Aug 2018 09:51:09 -0700 From: Davidlohr Bueso To: Waiman Long Cc: "Luis R. Rodriguez" , Kees Cook , Andrew Morton , Jonathan Corbet , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, Al Viro , Matthew Wilcox , "Eric W. Biederman" , Takashi Iwai , Davidlohr Bueso , manfred@colorfullife.com Subject: Re: [PATCH v8 1/5] ipc: IPCMNI limit check for msgmni and shmmni Message-ID: <20180817165109.GC32382@linux-r8p5> References: <1529317698-16575-1-git-send-email-longman@redhat.com> <1529317698-16575-2-git-send-email-longman@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: <1529317698-16575-2-git-send-email-longman@redhat.com> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 18 Jun 2018, Waiman Long wrote: >A user can write arbitrary integer values to msgmni and shmmni sysctl >parameters without getting error, but the actual limit is really >IPCMNI (32k). This can mislead users as they think they can get a >value that is not real. > >The right limits are now set for msgmni and shmmni so that the users >will become aware if they set a value outside of the acceptable range. > >Signed-off-by: Waiman Long Reviewed-by: Davidlohr Bueso >--- > ipc/ipc_sysctl.c | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/ipc/ipc_sysctl.c b/ipc/ipc_sysctl.c >index 8ad93c2..f87cb29 100644 >--- a/ipc/ipc_sysctl.c >+++ b/ipc/ipc_sysctl.c >@@ -99,6 +99,7 @@ static int proc_ipc_auto_msgmni(struct ctl_table *table, int write, > static int zero; > static int one = 1; > static int int_max = INT_MAX; >+static int ipc_mni = IPCMNI; > > static struct ctl_table ipc_kern_table[] = { > { >@@ -120,7 +121,9 @@ static int proc_ipc_auto_msgmni(struct ctl_table *table, int write, > .data = &init_ipc_ns.shm_ctlmni, > .maxlen = sizeof(init_ipc_ns.shm_ctlmni), > .mode = 0644, >- .proc_handler = proc_ipc_dointvec, >+ .proc_handler = proc_ipc_dointvec_minmax, >+ .extra1 = &zero, >+ .extra2 = &ipc_mni, > }, > { > .procname = "shm_rmid_forced", >@@ -147,7 +150,7 @@ static int proc_ipc_auto_msgmni(struct ctl_table *table, int write, > .mode = 0644, > .proc_handler = proc_ipc_dointvec_minmax, > .extra1 = &zero, >- .extra2 = &int_max, >+ .extra2 = &ipc_mni, > }, > { > .procname = "auto_msgmni", >-- >1.8.3.1 >