linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: John Whitmore <johnfwhitmore@gmail.com>
To: linux-kernel@vger.kernel.org
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
	John Whitmore <johnfwhitmore@gmail.com>
Subject: [PATCH 02/10] staging:rtl8192u: Rename sHTCLng - Style
Date: Fri, 17 Aug 2018 19:34:39 +0100	[thread overview]
Message-ID: <20180817183447.15993-3-johnfwhitmore@gmail.com> (raw)
In-Reply-To: <20180817183447.15993-1-johnfwhitmore@gmail.com>

The constant sHTCLng causes a checkpatch issue, due to its use of
CamelCase naming. To correct the issue the constant has been renamed
to HTCLNG.

I'm not sure this is a good name as it communicates very little and
contradicts the block comment above its definition. MCS_LEN might
be a better name if the block comment is correct.

Additionally the block comment has been changed to the recommended
style.

This is a coding style change which should have no impact on runtime
code execution.

Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
---
 drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c |  2 +-
 drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h   | 11 +++++------
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
index 28cae82d795c..5f41b41c514e 100644
--- a/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
+++ b/drivers/staging/rtl8192u/ieee80211/ieee80211_rx.c
@@ -794,7 +794,7 @@ static u8 parse_subframe(struct sk_buff *skb,
 	}
 
 	if (rx_stats->bContainHTC) {
-		LLCOffset += sHTCLng;
+		LLCOffset += HTCLNG;
 	}
 	// Null packet, don't indicate it to upper layer
 	ChkLength = LLCOffset;/* + (Frame_WEP(frame)!=0 ?Adapter->MgntInfo.SecurityInfo.EncryptionHeadOverhead:0);*/
diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
index 7d54a7cd9514..0c6d6b352497 100644
--- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
+++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
@@ -12,12 +12,11 @@
 //
 #define MIMO_PS_STATIC				0
 
-//
-//	There should be 128 bits to cover all of the MCS rates. However, since
-//	8190 does not support too much rates, one integer is quite enough.
-//
-
-#define sHTCLng	4
+/*
+ * There should be 128 bits to cover all of the MCS rates. However, since
+ * 8190 does not support too much rates, one integer is quite enough.
+ */
+#define HTCLNG	4
 
 
 #define HT_SUPPORTED_MCS_1SS_BITMAP					0x000000ff
-- 
2.18.0


  parent reply	other threads:[~2018-08-17 18:35 UTC|newest]

Thread overview: 11+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-17 18:34 [PATCH 00/10] staging:rtl8192u: Coding Style changes John Whitmore
2018-08-17 18:34 ` [PATCH 01/10] staging:rtl8192u: Replace magic number with defined constant - Style John Whitmore
2018-08-17 18:34 ` John Whitmore [this message]
2018-08-17 18:34 ` [PATCH 03/10] staging:rtl8192u: Remove unnecessary blank lines " John Whitmore
2018-08-17 18:34 ` [PATCH 04/10] staging:rtl8192u: Add required spaces " John Whitmore
2018-08-17 18:34 ` [PATCH 05/10] staging:rtl8192u: Remove unused constants " John Whitmore
2018-08-17 18:34 ` [PATCH 06/10] staging:rtl8192u: Correct block comments " John Whitmore
2018-08-17 18:34 ` [PATCH 07/10] staging:rtl8192u: Remove unused CHHLOP_IN_PROGRESS " John Whitmore
2018-08-17 18:34 ` [PATCH 08/10] staging:rtl8192u: Removed commented out structure " John Whitmore
2018-08-17 18:34 ` [PATCH 09/10] staging:rtl8192u: Remove enum CHNLOP " John Whitmore
2018-08-17 18:34 ` [PATCH 10/10] staging:rtl8192u: Refactor struct HT_CAPABILITY_ELE " John Whitmore

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180817183447.15993-3-johnfwhitmore@gmail.com \
    --to=johnfwhitmore@gmail.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=linux-kernel@vger.kernel.org \
    --subject='Re: [PATCH 02/10] staging:rtl8192u: Rename sHTCLng - Style' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).