From: kbuild test robot <lkp@intel.com>
To: Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
Cc: kbuild-all@01.org, boris.brezillon@bootlin.com,
miquel.raynal@bootlin.com, richard@nod.at, dwmw2@infradead.org,
computersforpeace@gmail.com, marek.vasut@gmail.com,
kyungmin.park@samsung.com, absahu@codeaurora.org,
peterpandong@micron.com, frieder.schrempf@exceet.de,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org,
michals@xilinx.com, nagasureshkumarrelli@gmail.com,
Naga Sureshkumar Relli <naga.sureshkumar.relli@xilinx.com>
Subject: Re: [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller
Date: Fri, 17 Aug 2018 23:30:34 +0800 [thread overview]
Message-ID: <201808172313.j6jWeSnL%fengguang.wu@intel.com> (raw)
In-Reply-To: <1534511964-20342-3-git-send-email-naga.sureshkumar.relli@xilinx.com>
[-- Attachment #1: Type: text/plain, Size: 3737 bytes --]
Hi Naga,
Thank you for the patch! Perhaps something to improve:
[auto build test WARNING on mtd/nand/next]
[also build test WARNING on next-20180817]
[cannot apply to v4.18]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]
url: https://github.com/0day-ci/linux/commits/Naga-Sureshkumar-Relli/Add-support-for-Arasan-NAND-Flash-controller/20180817-224117
base: git://git.infradead.org/linux-mtd.git nand/next
config: sh-allmodconfig (attached as .config)
compiler: sh4-linux-gnu-gcc (Debian 7.2.0-11) 7.2.0
reproduce:
wget https://raw.githubusercontent.com/intel/lkp-tests/master/sbin/make.cross -O ~/bin/make.cross
chmod +x ~/bin/make.cross
# save the attached .config to linux build tree
GCC_VERSION=7.2.0 make.cross ARCH=sh
All warnings (new ones prefixed by >>):
In file included from include/linux/scatterlist.h:9:0,
from include/linux/dma-mapping.h:11,
from drivers/mtd//nand/raw/arasan_nand.c:12:
drivers/mtd//nand/raw/arasan_nand.c: In function 'anfc_rw_dma_op':
>> drivers/mtd//nand/raw/arasan_nand.c:362:16: warning: right shift count >= width of type [-Wshift-count-overflow]
writel((paddr >> 32), nfc->base + DMA_ADDR1_OFST);
^
arch/sh/include/asm/io.h:31:77: note: in definition of macro '__raw_writel'
#define __raw_writel(v,a) (__chk_io_ptr(a), *(volatile u32 __force *)(a) = (v))
^
arch/sh/include/asm/io.h:46:62: note: in expansion of macro 'ioswabl'
#define writel_relaxed(v,c) ((void)__raw_writel((__force u32)ioswabl(v),c))
^~~~~~~
arch/sh/include/asm/io.h:56:32: note: in expansion of macro 'writel_relaxed'
#define writel(v,a) ({ wmb(); writel_relaxed((v),(a)); })
^~~~~~~~~~~~~~
>> drivers/mtd//nand/raw/arasan_nand.c:362:2: note: in expansion of macro 'writel'
writel((paddr >> 32), nfc->base + DMA_ADDR1_OFST);
^~~~~~
vim +362 drivers/mtd//nand/raw/arasan_nand.c
330
331 static void anfc_rw_dma_op(struct mtd_info *mtd, uint8_t *buf, int len,
332 bool do_read, u32 prog)
333 {
334 dma_addr_t paddr;
335 struct nand_chip *chip = mtd_to_nand(mtd);
336 struct anfc_nand_controller *nfc = to_anfc(chip->controller);
337 struct anfc_nand_chip *achip = to_anfc_nand(chip);
338 u32 eccintr = 0, dir;
339 u32 pktsize = len, pktcount = 1;
340
341 if (((nfc->curr_cmd == NAND_CMD_READ0)) ||
342 (nfc->curr_cmd == NAND_CMD_SEQIN && !nfc->iswriteoob)) {
343 pktsize = achip->pktsize;
344 pktcount = DIV_ROUND_UP(mtd->writesize, pktsize);
345 }
346 anfc_setpktszcnt(nfc, pktsize, pktcount);
347
348 if (!achip->bch && nfc->curr_cmd == NAND_CMD_READ0)
349 eccintr = MBIT_ERROR;
350
351 if (do_read)
352 dir = DMA_FROM_DEVICE;
353 else
354 dir = DMA_TO_DEVICE;
355
356 paddr = dma_map_single(nfc->dev, buf, len, dir);
357 if (dma_mapping_error(nfc->dev, paddr)) {
358 dev_err(nfc->dev, "Read buffer mapping error");
359 return;
360 }
361 writel(paddr, nfc->base + DMA_ADDR0_OFST);
> 362 writel((paddr >> 32), nfc->base + DMA_ADDR1_OFST);
363 anfc_enable_intrs(nfc, (XFER_COMPLETE | eccintr));
364 writel(prog, nfc->base + PROG_OFST);
365 anfc_wait_for_event(nfc);
366 dma_unmap_single(nfc->dev, paddr, len, dir);
367 }
368
---
0-DAY kernel test infrastructure Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all Intel Corporation
[-- Attachment #2: .config.gz --]
[-- Type: application/gzip, Size: 48801 bytes --]
next prev parent reply other threads:[~2018-08-17 15:30 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-17 13:19 [LINUX PATCH v10 0/2] Add support for Arasan NAND Flash controller Naga Sureshkumar Relli
2018-08-17 13:19 ` [LINUX PATCH v10 1/2] dt-bindings: mtd: arasan: Add device tree binding documentation Naga Sureshkumar Relli
2018-08-20 12:33 ` Boris Brezillon
2018-08-21 5:47 ` Naga Sureshkumar Relli
2018-08-21 5:59 ` Boris Brezillon
2018-08-21 9:22 ` Naga Sureshkumar Relli
2018-08-21 9:52 ` Miquel Raynal
2018-08-21 10:44 ` Naga Sureshkumar Relli
2018-08-21 10:52 ` Boris Brezillon
2018-08-21 11:10 ` Boris Brezillon
2018-08-17 13:19 ` [LINUX PATCH v10 2/2] mtd: rawnand: arasan: Add support for Arasan NAND Flash Controller Naga Sureshkumar Relli
2018-08-17 14:37 ` Miquel Raynal
2018-08-18 4:48 ` Naga Sureshkumar Relli
2018-08-17 15:30 ` kbuild test robot [this message]
2018-08-17 17:59 ` Boris Brezillon
2018-08-18 5:49 ` Naga Sureshkumar Relli
2018-08-20 8:53 ` Boris Brezillon
2018-08-20 10:49 ` Naga Sureshkumar Relli
2018-08-20 12:10 ` Boris Brezillon
2018-08-20 12:21 ` Naga Sureshkumar Relli
2018-08-20 12:24 ` Boris Brezillon
2018-08-20 16:40 ` Boris Brezillon
2018-08-21 6:40 ` Naga Sureshkumar Relli
2018-08-21 7:31 ` Miquel Raynal
2018-09-11 5:23 ` Naga Sureshkumar Relli
2018-09-22 7:53 ` Miquel Raynal
2018-09-22 8:13 ` Boris Brezillon
2018-09-24 8:42 ` Naga Sureshkumar Relli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201808172313.j6jWeSnL%fengguang.wu@intel.com \
--to=lkp@intel.com \
--cc=absahu@codeaurora.org \
--cc=boris.brezillon@bootlin.com \
--cc=computersforpeace@gmail.com \
--cc=dwmw2@infradead.org \
--cc=frieder.schrempf@exceet.de \
--cc=kbuild-all@01.org \
--cc=kyungmin.park@samsung.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marek.vasut@gmail.com \
--cc=michals@xilinx.com \
--cc=miquel.raynal@bootlin.com \
--cc=naga.sureshkumar.relli@xilinx.com \
--cc=nagasureshkumarrelli@gmail.com \
--cc=peterpandong@micron.com \
--cc=richard@nod.at \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).