From: Rob Herring <robh@kernel.org>
To: Brian Masney <masneyb@onstation.org>
Cc: dmitry.torokhov@gmail.com, linux-input@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
sebastian.reichel@collabora.co.uk, mark.rutland@arm.com
Subject: Re: [PATCH] dt-bindings: input: pwm-vibrator: correct pwm-names in example
Date: Mon, 20 Aug 2018 17:38:10 -0500 [thread overview]
Message-ID: <20180820223810.GA1780@bogus> (raw)
In-Reply-To: <20180818195855.13429-1-masneyb@onstation.org>
On Sat, Aug 18, 2018 at 03:58:55PM -0400, Brian Masney wrote:
> In the example for the pwm-vibrator bindings, pwm8 is the direction pin,
> and pwm9 is the enable pin. The pwm-names on the vibrator node has these
> two values swapped. This patch corrects the values for pwm-names.
>
> Signed-off-by: Brian Masney <masneyb@onstation.org>
> ---
> arch/arm/boot/dts/omap4-droid4-xt894.dts is actual implementation for
> the example and it is correct.
>
> Documentation/devicetree/bindings/input/pwm-vibrator.txt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Documentation/devicetree/bindings/input/pwm-vibrator.txt b/Documentation/devicetree/bindings/input/pwm-vibrator.txt
> index 09145d18491d..2731cbb7e8d7 100644
> --- a/Documentation/devicetree/bindings/input/pwm-vibrator.txt
> +++ b/Documentation/devicetree/bindings/input/pwm-vibrator.txt
> @@ -60,7 +60,7 @@ Example from Motorola Droid 4:
> compatible = "pwm-vibrator";
> pwms = <&pwm8 0 1000000000 0>,
> <&pwm9 0 1000000000 0>;
> - pwm-names = "enable", "direction";
> + pwm-names = "direction", "enable";
As enable is required and direction is optional, enable should come
first. So fix the pwms property instead. (And perhaps make the binding
more explicit as to what the order should be.
> direction-duty-cycle-ns = <1000000000>;
> };
> };
> --
> 2.17.1
>
prev parent reply other threads:[~2018-08-20 22:38 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-18 19:58 [PATCH] dt-bindings: input: pwm-vibrator: correct pwm-names in example Brian Masney
2018-08-20 22:38 ` Rob Herring [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180820223810.GA1780@bogus \
--to=robh@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dmitry.torokhov@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=masneyb@onstation.org \
--cc=sebastian.reichel@collabora.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).