* [PATCH] scsi: core: Update SCSI_MQ_DEFAULT help text to match default
@ 2018-08-21 11:44 Geert Uytterhoeven
2018-08-21 13:08 ` John Garry
` (2 more replies)
0 siblings, 3 replies; 4+ messages in thread
From: Geert Uytterhoeven @ 2018-08-21 11:44 UTC (permalink / raw)
To: Johannes Thumshirn, James E . J . Bottomley, Martin K . Petersen
Cc: Hannes Reinecke, Ming Lei, John Garry, linux-scsi, linux-kernel,
Geert Uytterhoeven
The default was changed, but the help text was not updated.
Fix grammar (s/the option/this option/) while at it.
Fixes: d5038a13eca72fb2 ("scsi: core: switch to scsi-mq by default")
Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
---
drivers/scsi/Kconfig | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
index 8fc851a9e1162a56..a0491e11bd359499 100644
--- a/drivers/scsi/Kconfig
+++ b/drivers/scsi/Kconfig
@@ -53,11 +53,11 @@ config SCSI_MQ_DEFAULT
depends on SCSI
---help---
This option enables the new blk-mq based I/O path for SCSI
- devices by default. With the option the scsi_mod.use_blk_mq
+ devices by default. With this option the scsi_mod.use_blk_mq
module/boot option defaults to Y, without it to N, but it can
still be overridden either way.
- If unsure say N.
+ If unsure say Y.
config SCSI_PROC_FS
bool "legacy /proc/scsi/ support"
--
2.17.1
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: core: Update SCSI_MQ_DEFAULT help text to match default
2018-08-21 11:44 [PATCH] scsi: core: Update SCSI_MQ_DEFAULT help text to match default Geert Uytterhoeven
@ 2018-08-21 13:08 ` John Garry
2018-08-21 13:19 ` Ming Lei
2018-08-24 1:44 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: John Garry @ 2018-08-21 13:08 UTC (permalink / raw)
To: Geert Uytterhoeven, Johannes Thumshirn, James E . J . Bottomley,
Martin K . Petersen
Cc: Hannes Reinecke, Ming Lei, linux-scsi, linux-kernel
On 21/08/2018 12:44, Geert Uytterhoeven wrote:
> The default was changed, but the help text was not updated.
>
> Fix grammar (s/the option/this option/) while at it.
>
> Fixes: d5038a13eca72fb2 ("scsi: core: switch to scsi-mq by default")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/scsi/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 8fc851a9e1162a56..a0491e11bd359499 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -53,11 +53,11 @@ config SCSI_MQ_DEFAULT
> depends on SCSI
> ---help---
> This option enables the new blk-mq based I/O path for SCSI
It's arguably not 'new' either :)
> - devices by default. With the option the scsi_mod.use_blk_mq
> + devices by default. With this option the scsi_mod.use_blk_mq
> module/boot option defaults to Y, without it to N, but it can
> still be overridden either way.
>
> - If unsure say N.
> + If unsure say Y.
>
> config SCSI_PROC_FS
> bool "legacy /proc/scsi/ support"
>
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: core: Update SCSI_MQ_DEFAULT help text to match default
2018-08-21 11:44 [PATCH] scsi: core: Update SCSI_MQ_DEFAULT help text to match default Geert Uytterhoeven
2018-08-21 13:08 ` John Garry
@ 2018-08-21 13:19 ` Ming Lei
2018-08-24 1:44 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Ming Lei @ 2018-08-21 13:19 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Johannes Thumshirn, James E . J . Bottomley, Martin K . Petersen,
Hannes Reinecke, John Garry, linux-scsi, linux-kernel
On Tue, Aug 21, 2018 at 01:44:07PM +0200, Geert Uytterhoeven wrote:
> The default was changed, but the help text was not updated.
>
> Fix grammar (s/the option/this option/) while at it.
>
> Fixes: d5038a13eca72fb2 ("scsi: core: switch to scsi-mq by default")
> Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
> ---
> drivers/scsi/Kconfig | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig
> index 8fc851a9e1162a56..a0491e11bd359499 100644
> --- a/drivers/scsi/Kconfig
> +++ b/drivers/scsi/Kconfig
> @@ -53,11 +53,11 @@ config SCSI_MQ_DEFAULT
> depends on SCSI
> ---help---
> This option enables the new blk-mq based I/O path for SCSI
> - devices by default. With the option the scsi_mod.use_blk_mq
> + devices by default. With this option the scsi_mod.use_blk_mq
> module/boot option defaults to Y, without it to N, but it can
> still be overridden either way.
>
> - If unsure say N.
> + If unsure say Y.
>
> config SCSI_PROC_FS
> bool "legacy /proc/scsi/ support"
> --
> 2.17.1
>
Looks fine,
Reviewed-by: Ming Lei <ming.lei@redhat.com>
Thanks,
Ming
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH] scsi: core: Update SCSI_MQ_DEFAULT help text to match default
2018-08-21 11:44 [PATCH] scsi: core: Update SCSI_MQ_DEFAULT help text to match default Geert Uytterhoeven
2018-08-21 13:08 ` John Garry
2018-08-21 13:19 ` Ming Lei
@ 2018-08-24 1:44 ` Martin K. Petersen
2 siblings, 0 replies; 4+ messages in thread
From: Martin K. Petersen @ 2018-08-24 1:44 UTC (permalink / raw)
To: Geert Uytterhoeven
Cc: Johannes Thumshirn, James E . J . Bottomley, Martin K . Petersen,
Hannes Reinecke, Ming Lei, John Garry, linux-scsi, linux-kernel
Geert,
> The default was changed, but the help text was not updated.
Applied to 4.19/scsi-fixes, thanks!
--
Martin K. Petersen Oracle Linux Engineering
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2018-08-24 1:44 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-21 11:44 [PATCH] scsi: core: Update SCSI_MQ_DEFAULT help text to match default Geert Uytterhoeven
2018-08-21 13:08 ` John Garry
2018-08-21 13:19 ` Ming Lei
2018-08-24 1:44 ` Martin K. Petersen
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).