From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F08FFC4321D for ; Wed, 22 Aug 2018 06:20:57 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 5E470214C4 for ; Wed, 22 Aug 2018 06:20:57 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5E470214C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728232AbeHVJoU (ORCPT ); Wed, 22 Aug 2018 05:44:20 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:34888 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728020AbeHVJoU (ORCPT ); Wed, 22 Aug 2018 05:44:20 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1fsMVa-0006GI-KH; Wed, 22 Aug 2018 14:20:46 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1fsMVQ-0006jN-O1; Wed, 22 Aug 2018 14:20:36 +0800 Date: Wed, 22 Aug 2018 14:20:36 +0800 From: Herbert Xu To: Ard Biesheuvel Cc: Eric Biggers , Megha Dey , Tim Chen , "David S. Miller" , syzbot , "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Linux Kernel Mailing List , syzkaller-bugs , the arch/x86 maintainers Subject: Re: KASAN: use-after-free Read in sha512_ctx_mgr_resubmit Message-ID: <20180822062036.mdq4q5o5zdzuxh7s@gondor.apana.org.au> References: <00000000000072d64d05737b6b8c@google.com> <20180820073119.GA14931@sol.localdomain> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 21, 2018 at 02:43:56PM +0200, Ard Biesheuvel wrote: > > I agree. The code is obviously broken in a way that would have been > noticed if it were in wide use, and it is too complicated for mere > mortals to fix or maintain. I suggest we simply remove it for now, and > if anyone wants to reintroduce it, we can review the code *and* the > justification for the approach from scratch (in which case we should > consider factoring out the algo agnostics plumbing in a way that > allows it to be reused by other architectures as well) I agree too. Could one of you guys send me a patch to remove them? Thanks, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt