From: Johan Hovold <johan@kernel.org>
To: Keerthy <j-keerthy@ti.com>
Cc: tony@atomide.com, d-gerlach@ti.com, linux-kernel@vger.kernel.org,
t-kristo@ti.com, ssantosh@kernel.org, linux-omap@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH] soc: ti: pm33xx: Enable DS0 for the platforms on which it is functional
Date: Wed, 22 Aug 2018 09:34:09 +0200 [thread overview]
Message-ID: <20180822073409.GK14967@localhost> (raw)
In-Reply-To: <1534915951-8783-1-git-send-email-j-keerthy@ti.com>
On Wed, Aug 22, 2018 at 11:02:31AM +0530, Keerthy wrote:
> Enable DS0 for only those platforms on which it is functional
>
> Signed-off-by: Keerthy <j-keerthy@ti.com>
> ---
> arch/arm/mach-omap2/pm33xx-core.c | 5 +++++
> drivers/soc/ti/pm33xx.c | 9 +++++++++
> include/linux/platform_data/pm33xx.h | 2 ++
> 3 files changed, 16 insertions(+)
>
> diff --git a/arch/arm/mach-omap2/pm33xx-core.c b/arch/arm/mach-omap2/pm33xx-core.c
> index f4971e4..f0f6e8e 100644
> --- a/arch/arm/mach-omap2/pm33xx-core.c
> +++ b/arch/arm/mach-omap2/pm33xx-core.c
> @@ -135,6 +135,11 @@ static int am43xx_suspend(unsigned int state, int (*fn)(unsigned long),
> {
> int ret = 0;
>
> + if (!(args & WFI_FLAG_DEEP_SLEEP0)) {
> + pr_err("DS0 mode not supported\n");
> + return -ENOTSUPP;
> + }
> +
> amx3_pre_suspend_common();
> scu_power_mode(scu_base, SCU_PM_POWEROFF);
> ret = cpu_suspend(args, fn);
> diff --git a/drivers/soc/ti/pm33xx.c b/drivers/soc/ti/pm33xx.c
> index d0dab32..53238d7 100644
> --- a/drivers/soc/ti/pm33xx.c
> +++ b/drivers/soc/ti/pm33xx.c
> @@ -324,6 +324,15 @@ static int am33xx_pm_probe(struct platform_device *pdev)
> suspend_wfi_flags |= WFI_FLAG_SAVE_EMIF;
> suspend_wfi_flags |= WFI_FLAG_WAKE_M3;
>
> + /*
> + * Deep Sleep0 mode is currently functional only on am437x-gp-evm,
> + * am33xx-evm and boneblack family. Hence set the DS0 flag
> + */
> + if (of_machine_is_compatible("ti,am437x-gp-evm") ||
> + of_machine_is_compatible("ti,am335x-bone-black") ||
> + of_machine_is_compatible("ti,am335x-evm"))
> + suspend_wfi_flags |= WFI_FLAG_DEEP_SLEEP0;
What about other (out-of-tree) machines which supports DS0 and which
this change would break?
I think this needs to be a blacklist if anything.
Please also expand in the commit message why you think this is needed.
Last, what tree is this against? There's no am43xx_suspend() in
linux-next (and you add compatibles above for am33xx too).
Thanks,
Johan
next prev parent reply other threads:[~2018-08-22 7:34 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 5:32 [PATCH] soc: ti: pm33xx: Enable DS0 for the platforms on which it is functional Keerthy
2018-08-22 7:34 ` Johan Hovold [this message]
2018-08-22 7:37 ` Johan Hovold
2018-08-22 8:20 ` J, KEERTHY
2018-08-22 8:43 ` Johan Hovold
2018-08-22 11:07 ` J, KEERTHY
2018-08-22 14:22 ` Tony Lindgren
2018-08-27 7:05 ` Johan Hovold
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822073409.GK14967@localhost \
--to=johan@kernel.org \
--cc=d-gerlach@ti.com \
--cc=j-keerthy@ti.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-omap@vger.kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=tony@atomide.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).