From: Steven Rostedt <rostedt@goodmis.org>
To: Masami Hiramatsu <mhiramat@kernel.org>
Cc: Francis Deslauriers <francis.deslauriers@efficios.com>,
peterz@infradead.org, mathieu.desnoyers@efficios.com,
linux-kernel@vger.kernel.org,
Michael Rodin <michael@rodin.online>,
Ravi Bangoria <ravi.bangoria@linux.ibm.com>,
linux-perf-users@vger.kernel.org,
Arnaldo Carvalho de Melo <acme@kernel.org>
Subject: Re: [BUGFIX PATCH] tracing/kprobes: Fix to check notrace function with correct range
Date: Wed, 22 Aug 2018 08:58:09 -0400 [thread overview]
Message-ID: <20180822085809.01da04b0@gandalf.local.home> (raw)
In-Reply-To: <20180821094249.3fea76bb@gandalf.local.home>
On Tue, 21 Aug 2018 09:42:49 -0400
Steven Rostedt <rostedt@goodmis.org> wrote:
> On Tue, 21 Aug 2018 22:04:57 +0900
> Masami Hiramatsu <mhiramat@kernel.org> wrote:
>
> > Fix within_notrace_func() to check notrace function correctly.
> >
> > Since the ftrace_location_range(start, end) function checks
> > the range inclusively (start <= ftrace-loc <= end), the end
> > address must not include the entry address of next function.
> >
> > However, within_notrace_func() uses kallsyms_lookup_size_offset()
> > to get the function size and calculate the end address from
> > adding the size to the entry address. This means the end address
> > is the entry address of the next function.
> >
> > In the result, within_notrace_func() fails to find notrace
> > function if the next function of the target function is
> > ftraced.
> >
> > Let's subtract 1 from the end address so that ftrace_location_range()
> > can check it correctly.
> >
> > Fixes: commit 45408c4f9250 ("tracing: kprobes: Prohibit probing on notrace function")
> > Signed-off-by: Masami Hiramatsu <mhiramat@kernel.org>
> > Reported-by: Michael Rodin <michael@rodin.online>
> > ---
> >
>
> Applied. Thanks Masami! I'll start testing this and send it upstream
> when it's finished.
>
Hmm, this fix shows the extent of not tracing functions with notrace
attched much deeper. For one thing, we can't hook kprobes to the
__schedule() function (which is now what all the main schedule
functions call). One of my tests used this function to test kprobes and
it failed.
I'll push this to Linus, but I'm wondering if we want to perhaps add a
white list of functions marked "notrace" but still kprobes can trace?
-- Steve
next prev parent reply other threads:[~2018-08-22 12:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20180821212448.d20ea26fa998b206adf4ece6@kernel.org>
2018-08-21 13:04 ` [BUGFIX PATCH] tracing/kprobes: Fix to check notrace function with correct range Masami Hiramatsu
2018-08-21 13:42 ` Steven Rostedt
2018-08-22 12:58 ` Steven Rostedt [this message]
2018-08-23 1:18 ` Masami Hiramatsu
2018-08-23 1:39 ` Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822085809.01da04b0@gandalf.local.home \
--to=rostedt@goodmis.org \
--cc=acme@kernel.org \
--cc=francis.deslauriers@efficios.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-perf-users@vger.kernel.org \
--cc=mathieu.desnoyers@efficios.com \
--cc=mhiramat@kernel.org \
--cc=michael@rodin.online \
--cc=peterz@infradead.org \
--cc=ravi.bangoria@linux.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).