From: Kunihiko Hayashi <hayashi.kunihiko@socionext.com>
To: Hans de Goede <hdegoede@redhat.com>
Cc: Tejun Heo <tj@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, <linux-ide@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 00/14] ata: ahci-platform: add reset control support except for existing drivers
Date: Wed, 22 Aug 2018 19:06:14 +0900 [thread overview]
Message-ID: <20180822190614.974F.4A936039@socionext.com> (raw)
In-Reply-To: <cd35711a-5308-519d-7064-b82220a36d57@redhat.com>
Hi Hans,
Thank you for your comment.
On Wed, 22 Aug 2018 11:27:18 +0200 <hdegoede@redhat.com> wrote:
> Hi,
>
> On 22-08-18 09:36, Kunihiko Hayashi wrote:
> > Add support to get and control a list of resets for the device, and
> > add the flag indicating whether to use the reset. Existing drivers
> > set 0 to this flags.
> > > This series solves the issue of the previous patch [1] that was already
> > reverted [2].
> > [1] https://www.spinics.net/lists/linux-ide/msg55299.html
> > [2] https://www.spinics.net/lists/linux-ide/msg55379.html
> > > Kunihiko Hayashi (14):
> > ata: ahci-platform: add reset control support and the flag to specify
> > using reset
> > ata: ahci_brcm: add second argument of ahci_platform_get_resources()
> > ata: ahci_ceva: add second argument of ahci_platform_get_resources()
> > ata: ahci_da850: add second argument of ahci_platform_get_resources()
> > ata: ahci_dm816: add second argument of ahci_platform_get_resources()
> > ata: ahci_imx: add second argument of ahci_platform_get_resources()
> > ata: ahci_brcm: add second argument of ahci_platform_get_resources()
> > ata: ahci_mvebu: add second argument of ahci_platform_get_resources()
> > ata: ahci_qoriq: add second argument of ahci_platform_get_resources()
> > ata: ahci_seattle: add second argument of
> > ahci_platform_get_resources()
> > ata: ahci_st: add second argument of ahci_platform_get_resources()
> > ata: ahci_sunxi: add second argument of ahci_platform_get_resources()
> > ata: ahci_tegra: add second argument of ahci_platform_get_resources()
> > ata: ahci_xgene: add second argument of ahci_platform_get_resources()
>
> When you change a function prototype, you must also change all
> the callers in a single commit, so that all intermediate commits
> will compile without errors, otherwise you will break git bisect.
Surely, these splitted patches will make git bisect fail.
I'll collect them in a single commit.
> Otherwise this looks good.
>
> I suggest you split this like this:
>
> 1) Add a flags argument to ahci_platform_get_resources(),
> without adding support for any flags yet, so this just
> changes the function prototype and passes 0 for the new
> flags argument *everywhere* without any other changes
> 2) Add support for a AHCI_PLATFORM_GET_RESETS flag, basically
> your current first patch, minus the prototype patches
> 3) A patch which passes AHCI_PLATFORM_GET_RESETS for the
> generic ahci_platform driver (so break this out of your
> first patch). Also describe in the commit message of this
> patch why / for which platforms this is necessary.
>
> The idea of doing 3. separately is that we can easily revert
> it in case of problems while keeping the core functionality
> in place. Note I do not expect this to be necessary.
Your split plan will be very useful for bisecting. I'll try it next.
---
Best Regards,
Kunihiko Hayashi
prev parent reply other threads:[~2018-08-22 10:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-22 7:36 [PATCH 00/14] ata: ahci-platform: add reset control support except for existing drivers Kunihiko Hayashi
2018-08-22 7:36 ` [PATCH 01/14] ata: ahci-platform: add reset control support and the flag to specify using reset Kunihiko Hayashi
2018-08-22 9:34 ` Sergei Shtylyov
2018-08-22 10:06 ` Kunihiko Hayashi
2018-08-22 7:36 ` [PATCH 02/14] ata: ahci_brcm: add second argument of ahci_platform_get_resources() Kunihiko Hayashi
2018-08-22 7:36 ` [PATCH 03/14] ata: ahci_ceva: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 04/14] ata: ahci_da850: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 05/14] ata: ahci_dm816: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 06/14] ata: ahci_imx: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 07/14] ata: ahci_brcm: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 08/14] ata: ahci_mvebu: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 09/14] ata: ahci_qoriq: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 10/14] ata: ahci_seattle: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 11/14] ata: ahci_st: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 12/14] ata: ahci_sunxi: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 13/14] ata: ahci_tegra: " Kunihiko Hayashi
2018-08-22 7:37 ` [PATCH 14/14] ata: ahci_xgene: " Kunihiko Hayashi
2018-08-22 9:27 ` [PATCH 00/14] ata: ahci-platform: add reset control support except for existing drivers Hans de Goede
2018-08-22 10:06 ` Kunihiko Hayashi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180822190614.974F.4A936039@socionext.com \
--to=hayashi.kunihiko@socionext.com \
--cc=devicetree@vger.kernel.org \
--cc=hdegoede@redhat.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=robh+dt@kernel.org \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).