From: Michal Hocko <mhocko@kernel.org>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: "kbuild test robot" <lkp@intel.com>,
kbuild-all@01.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org,
"Kirill A . Shutemov" <kirill.shutemov@linux.intel.com>,
"Jérôme Glisse" <jglisse@redhat.com>,
"Vlastimil Babka" <vbabka@suse.cz>,
"Naoya Horiguchi" <n-horiguchi@ah.jp.nec.com>,
"Davidlohr Bueso" <dave@stgolabs.net>,
"Andrew Morton" <akpm@linux-foundation.org>,
stable@vger.kernel.org
Subject: Re: [PATCH v3 1/2] mm: migration: fix migration of huge PMD shared pages
Date: Thu, 23 Aug 2018 09:30:35 +0200 [thread overview]
Message-ID: <20180823073035.GT29735@dhcp22.suse.cz> (raw)
In-Reply-To: <4a95a24f-534f-0938-f358-2a410817a412@oracle.com>
On Wed 22-08-18 09:48:16, Mike Kravetz wrote:
> On 08/22/2018 05:28 AM, Michal Hocko wrote:
> > On Tue 21-08-18 18:10:42, Mike Kravetz wrote:
> > [...]
> >> diff --git a/mm/rmap.c b/mm/rmap.c
> >> index eb477809a5c0..8cf853a4b093 100644
> >> --- a/mm/rmap.c
> >> +++ b/mm/rmap.c
> >> @@ -1362,11 +1362,21 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
> >> }
> >>
> >> /*
> >> - * We have to assume the worse case ie pmd for invalidation. Note that
> >> - * the page can not be free in this function as call of try_to_unmap()
> >> - * must hold a reference on the page.
> >> + * For THP, we have to assume the worse case ie pmd for invalidation.
> >> + * For hugetlb, it could be much worse if we need to do pud
> >> + * invalidation in the case of pmd sharing.
> >> + *
> >> + * Note that the page can not be free in this function as call of
> >> + * try_to_unmap() must hold a reference on the page.
> >> */
> >> end = min(vma->vm_end, start + (PAGE_SIZE << compound_order(page)));
> >> + if (PageHuge(page)) {
> >> + /*
> >> + * If sharing is possible, start and end will be adjusted
> >> + * accordingly.
> >> + */
> >> + (void)huge_pmd_sharing_possible(vma, &start, &end);
> >> + }
> >> mmu_notifier_invalidate_range_start(vma->vm_mm, start, end);
> >
> > I do not get this part. Why don't we simply unconditionally invalidate
> > the whole huge page range?
>
> In this routine, we are only unmapping a single page. The existing code
> is limiting the invalidate range to that page size: 4K or 2M. With shared
> PMDs, we have the possibility of unmapping a PUD_SIZE area: 1G. I don't
> think we want to unconditionally invalidate 1G. Is that what you are asking?
But we know that huge_pmd_unshare unmapped a shared pte so we know when
to flush 2MB or 1GB. I really do not like how huge_pmd_sharing_possible
a) duplicates some checks and b) it updates start/stop out of line.
> I do not know how often PMD sharing is exercised. It certainly is used by
> DBs for large shared areas. I suspect it is less frequent than hugtlb pages
> in general, and certainly less frequent than THP or base pages.
>
> >>
> >> while (page_vma_mapped_walk(&pvmw)) {
> >> @@ -1409,6 +1419,32 @@ static bool try_to_unmap_one(struct page *page, struct vm_area_struct *vma,
> >> subpage = page - page_to_pfn(page) + pte_pfn(*pvmw.pte);
> >> address = pvmw.address;
> >>
> >> + if (PageHuge(page)) {
> >> + if (huge_pmd_unshare(mm, &address, pvmw.pte)) {
> >
> > huge_pmd_unshare is documented to require a pte lock. Where do we take
> > it?
>
> It is somewhat hidden, but we are in the loop:
>
> while (page_vma_mapped_walk(&pvmw)) {
>
> The routine page_vma_mapped_walk will acquire the lock, and it correctly
> checks for huge pages and uses huge_pte_lockptr().
>
> page_vma_mapped_walk_done() will release the lock.
OK, I can see it now. Thanks for the clarification. page_vma_mapped_walk
is quite hard to follow.
--
Michal Hocko
SUSE Labs
next prev parent reply other threads:[~2018-08-23 7:30 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-21 20:59 [PATCH v3 0/2] huge_pmd_unshare migration and flushing Mike Kravetz
2018-08-21 20:59 ` [PATCH v3 1/2] mm: migration: fix migration of huge PMD shared pages Mike Kravetz
2018-08-21 22:03 ` kbuild test robot
2018-08-21 23:06 ` Mike Kravetz
2018-08-22 0:51 ` kbuild test robot
2018-08-22 1:10 ` Mike Kravetz
2018-08-22 12:28 ` Michal Hocko
2018-08-22 16:48 ` Mike Kravetz
2018-08-23 7:30 ` Michal Hocko [this message]
2018-08-23 8:21 ` Kirill A. Shutemov
2018-08-23 10:33 ` Michal Hocko
2018-08-23 16:45 ` Mike Kravetz
2018-08-22 21:05 ` Kirill A. Shutemov
2018-08-22 21:48 ` Mike Kravetz
2018-08-23 12:48 ` Michal Hocko
2018-08-23 17:01 ` Mike Kravetz
2018-08-23 17:56 ` Mike Kravetz
2018-08-23 19:36 ` Michal Hocko
2018-08-21 20:59 ` [PATCH v3 2/2] hugetlb: take PMD sharing into account when flushing tlb/caches Mike Kravetz
2018-08-21 23:07 ` kbuild test robot
2018-08-22 1:20 ` kbuild test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180823073035.GT29735@dhcp22.suse.cz \
--to=mhocko@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=dave@stgolabs.net \
--cc=jglisse@redhat.com \
--cc=kbuild-all@01.org \
--cc=kirill.shutemov@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=lkp@intel.com \
--cc=mike.kravetz@oracle.com \
--cc=n-horiguchi@ah.jp.nec.com \
--cc=stable@vger.kernel.org \
--cc=vbabka@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).