From: Dmitry Torokhov <dmitry.torokhov@gmail.com>
To: Mark Brown <broonie@kernel.org>
Cc: ryans.lee@maximintegrated.com,
Liam Girdwood <lgirdwood@gmail.com>,
Jaroslav Kysela <perex@perex.cz>, Takashi Iwai <tiwai@suse.com>,
Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>,
"alsa-devel@alsa-project.org" <alsa-devel@alsa-project.org>,
lkml <linux-kernel@vger.kernel.org>,
ryan.lee.maxim@gmail.com
Subject: Re: [PATCH] ASoC: max98373: Added 10ms delay after amp software reset
Date: Thu, 23 Aug 2018 17:08:07 -0700 [thread overview]
Message-ID: <20180824000807.GF53155@dtor-ws> (raw)
In-Reply-To: <20180823095107.GA5207@sirena.org.uk>
On Thu, Aug 23, 2018 at 10:51:07AM +0100, Mark Brown wrote:
> On Wed, Aug 22, 2018 at 05:31:04PM -0700, Dmitry Torokhov wrote:
> > On Wed, Aug 22, 2018 at 5:21 PM Ryan Lee <ryans.lee@maximintegrated.com> wrote:
> > > + mdelay(10);
>
> > Is it really necessary for the CPU to spin for 10msec here?
> > usleep_range() would be better solution.
>
> Or msleep() for that matter, it's not going ot be the end of the world
> if we delay a bit too long.
Frankly, I'd rather we did not introduce extra delays. I do not know if
we use this part, but on ChromeOS we are interested in shaving as much
from the boot time as possible and 10 msecs here and 10 msecs there do
add up.
Thanks.
--
Dmitry
next prev parent reply other threads:[~2018-08-24 0:08 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 0:15 [PATCH] ASoC: max98373: Added 10ms delay after amp software reset Ryan Lee
2018-08-23 0:31 ` Dmitry Torokhov
2018-08-23 9:51 ` Mark Brown
2018-08-24 0:08 ` Dmitry Torokhov [this message]
2018-08-24 1:00 ` Ryan Lee
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180824000807.GF53155@dtor-ws \
--to=dmitry.torokhov@gmail.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=kuninori.morimoto.gx@renesas.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=ryan.lee.maxim@gmail.com \
--cc=ryans.lee@maximintegrated.com \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).