From: Russ Anderson <rja@hpe.com>
To: minyard@acm.org
Cc: Andrew Banman <abanman@hpe.com>,
openipmi-developer@lists.sourceforge.net,
linux-kernel@vger.kernel.org, frank.ramsay@hpe.com,
justin.ernst@hpe.com
Subject: Re: [PATCH 0/2] ipmi: Fix issues in the BT code.
Date: Thu, 23 Aug 2018 22:57:05 -0500 [thread overview]
Message-ID: <20180824035705.bu4gnt3m622qa3pa@hpe.com> (raw)
In-Reply-To: <1535056623-26634-1-git-send-email-minyard@acm.org>
On Thu, Aug 23, 2018 at 03:37:01PM -0500, minyard@acm.org wrote:
> The first change fixes the race condition at startup between
> capabilities detection and the startup of the upper layers of
> the IPMI driver.
>
> The second is cleanup code that I'm doing as I touch things in the
> driver.
Quick testing looks good. This was with your patch backported to RHEL7.6.
More testing tomorrow but so far so good.
[root@ah-038 ~]# dmesg | grep -i ipmi
[ 76.409474] ipmi message handler version 39.2
[ 76.529702] ipmi device interface
[ 76.773727] IPMI System Interface driver.
[ 76.778277] ipmi_si ipmi_si.0: ipmi_platform: probing via SMBIOS
[ 76.784999] ipmi_si: SMBIOS: mem 0xce4 regsize 1 spacing 1 irq 6
[ 76.806979] ipmi_si: Adding SMBIOS-specified bt state machine
[ 76.813903] ipmi_si IPI0001:00: ipmi_platform: probing via ACPI
[ 76.833722] ipmi_si IPI0001:00: [io 0x0ce4-0x0ce6] regsize 1 spacing 1 irq 6
[ 76.842593] ipmi_si: Adding ACPI-specified bt state machine
[ 76.842980] ipmi_platform: probing via SPMI
[ 76.842982] ipmi_si: SPMI: io 0xce4 regsize 1 spacing 1 irq 6
[ 76.845116] ipmi_si: Trying SMBIOS-specified bt state machine at mem address 0xce4, slave address 0x20, irq 6
[ 76.845123] ipmi_si ipmi_si.0: Could not set up I/O space
[ 76.939459] ipmi_si: Trying ACPI-specified bt state machine at i/o address 0xce4, slave address 0x0, irq 6
[ 76.959709] ipmi_si IPI0001:00: Using irq 6
[ 76.993053] ipmi_si IPI0001:00: Found new BMC (man_id: 0x000000, prod_id: 0x0101, dev_id: 0x20)
[ 77.063491] ipmi_si IPI0001:00: IPMI bt interface initialized
Thanks.
--
Russ Anderson, SuperDome Flex Linux Kernel Group Manager
HPE - Hewlett Packard Enterprise (formerly SGI) rja@hpe.com
prev parent reply other threads:[~2018-08-24 3:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 20:37 [PATCH 0/2] ipmi: Fix issues in the BT code minyard
2018-08-23 20:37 ` [PATCH 1/2] ipmi: Move BT capabilities detection to the detect call minyard
2018-08-27 20:16 ` Banman, Andrew
2018-08-27 20:47 ` Corey Minyard
2018-08-23 20:37 ` [PATCH 2/2] ipmi: Convert pr_xxx() to dev_xxx() in the BT code minyard
2018-08-24 3:57 ` Russ Anderson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180824035705.bu4gnt3m622qa3pa@hpe.com \
--to=rja@hpe.com \
--cc=abanman@hpe.com \
--cc=frank.ramsay@hpe.com \
--cc=justin.ernst@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=minyard@acm.org \
--cc=openipmi-developer@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).