From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C3DA9C4321D for ; Fri, 24 Aug 2018 04:12:53 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 61EF12157C for ; Fri, 24 Aug 2018 04:12:53 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="ps9wMPRK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 61EF12157C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726554AbeHXHpj (ORCPT ); Fri, 24 Aug 2018 03:45:39 -0400 Received: from mail.kernel.org ([198.145.29.99]:50846 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726198AbeHXHpj (ORCPT ); Fri, 24 Aug 2018 03:45:39 -0400 Received: from localhost (LFbn-NCY-1-241-207.w83-194.abo.wanadoo.fr [83.194.85.207]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 51EDF208E9; Fri, 24 Aug 2018 04:12:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1535083969; bh=XMb/OOMkyFLTs/V2TC62Q8LgoyU0qaWb0N9yklEl97I=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=ps9wMPRKvZJyxgTz8uLMMitBHEYcCy0ZYBVZAgY7p4I0lRPq/F4HXICyTK9j8eNqX wx0JkvxKAqNd0ma9gVy9YJ+PwQdQRg9Ls7yhuOh/H+sLUAqRe2VOz6pHZ6WlRGPKUF tsKa5hpPeI2K9kFeXMI59joilAB+VFaF4aYxw9mE= Date: Fri, 24 Aug 2018 06:12:46 +0200 From: Frederic Weisbecker To: Heiner Kallweit Cc: Anna-Maria Gleixner , Thomas Gleixner , Linux Kernel Mailing List , Grygorii Strashko Subject: Re: Fix 80d20d35af1e ("nohz: Fix local_timer_softirq_pending()") may have revealed another problem Message-ID: <20180824041245.GA2730@lerouge> References: <8b93f213-fe67-f132-f3f5-5b17995ec63d@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8b93f213-fe67-f132-f3f5-5b17995ec63d@gmail.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 16, 2018 at 08:13:03AM +0200, Heiner Kallweit wrote: > Recently I started to get warning "NOHZ: local_softirq_pending 202" and > I think it's related to mentioned commit (didn't bisect it yet). > See log from suspending. > > I have no reason to think the fix is wrong, it may just have revealed > another issue which existed before and was hidden by the bug. > > Rgds, Heiner > > [ 75.073353] random: crng init done > [ 75.073402] random: 7 urandom warning(s) missed due to ratelimiting > [ 78.619564] PM: suspend entry (deep) > [ 78.619675] PM: Syncing filesystems ... done. > [ 78.653684] Freezing user space processes ... (elapsed 0.002 seconds) done. > [ 78.656094] OOM killer disabled. > [ 78.656113] Freezing remaining freezable tasks ... (elapsed 0.001 seconds) done. > [ 78.658177] Suspending console(s) (use no_console_suspend to debug) > [ 78.663066] nuvoton-cir 00:07: disabled > [ 78.671817] sd 0:0:0:0: [sda] Synchronizing SCSI cache > [ 78.672210] sd 0:0:0:0: [sda] Stopping disk > [ 78.786651] ACPI: Preparing to enter system sleep state S3 > [ 78.789613] PM: Saving platform NVS memory > [ 78.789759] Disabling non-boot CPUs ... > [ 78.805154] NOHZ: local_softirq_pending 202 > [ 78.805182] NOHZ: local_softirq_pending 202 > [ 78.807102] smpboot: CPU 1 is now offline I've tried to reproduce with suspend on disk but got unsuccessful. A small question as I see someone is having a similar issue with a stable release only. On which kernel did you trigger that: upstream or stable? I'll continue investigating. Thanks.