From: Herbert Xu <herbert@gondor.apana.org.au>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
linux-crypto@vger.kernel.org, Mike Snitzer <msnitzer@redhat.com>,
dm-devel@redhat.com, linux-kernel@vger.kernel.org
Subject: Re: Deadlock when using crypto API for block devices
Date: Fri, 24 Aug 2018 19:25:18 +0800 [thread overview]
Message-ID: <20180824112517.pct5bwdlhfdtqwil@gondor.apana.org.au> (raw)
In-Reply-To: <alpine.LRH.2.02.1808240711380.28952@file01.intranet.prod.int.rdu2.redhat.com>
On Fri, Aug 24, 2018 at 07:22:19AM -0400, Mikulas Patocka wrote:
>
> And also ablkcipher_next_slow, ablkcipher_copy_iv, skcipher_next_slow,
> skcipher_next_copy, skcipher_copy_iv, blkcipher_next_slow,
> blkcipher_copy_iv.
>
> So, I think that dropping CRYPTO_TFM_REQ_MAY_SLEEP is not possible.
These should never trigger for dm-crypt AFAICS since it only
happens if you provide unaligned input/output.
Cheers,
--
Email: Herbert Xu <herbert@gondor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt
next prev parent reply other threads:[~2018-08-24 11:25 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-23 20:39 Deadlock when using crypto API for block devices Mikulas Patocka
2018-08-24 2:10 ` Herbert Xu
2018-08-24 11:06 ` Mikulas Patocka
2018-08-24 11:22 ` Mikulas Patocka
2018-08-24 11:25 ` Herbert Xu [this message]
2018-08-24 11:24 ` Herbert Xu
2018-08-24 12:37 ` Mikulas Patocka
2018-08-24 13:00 ` Mikulas Patocka
2018-08-24 13:21 ` Herbert Xu
2018-08-24 13:22 ` Herbert Xu
2018-08-24 16:02 ` Dave Watson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180824112517.pct5bwdlhfdtqwil@gondor.apana.org.au \
--to=herbert@gondor.apana.org.au \
--cc=davem@davemloft.net \
--cc=dm-devel@redhat.com \
--cc=linux-crypto@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
--cc=msnitzer@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).