* [PATCH v3 1/2] arm64: dts: msm: add PDC device bindings for sdm845
@ 2018-08-24 19:11 Lina Iyer
2018-08-24 19:11 ` [PATCH v3 2/2] dt-bindings/interrupt-controller: pdc: fix example to match actual bindings Lina Iyer
0 siblings, 1 reply; 3+ messages in thread
From: Lina Iyer @ 2018-08-24 19:11 UTC (permalink / raw)
To: marc.zyngier, bjorn.andersson, sboyd, evgreen, linus.walleij
Cc: rplsssn, linux-kernel, linux-arm-msm, rnayak, devicetree,
andy.gross, dianders, Lina Iyer
Add PDC interrupt controller device bindings for SDM845.
Signed-off-by: Lina Iyer <ilina@codeaurora.org>
---
Changes in v3:
- Fix PDC map, use GIC SPI port number for hwirq
Changes in v2:
- Order by address
---
arch/arm64/boot/dts/qcom/sdm845.dtsi | 9 +++++++++
1 file changed, 9 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845.dtsi b/arch/arm64/boot/dts/qcom/sdm845.dtsi
index b3d7af097edf..0208f8557ffa 100644
--- a/arch/arm64/boot/dts/qcom/sdm845.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845.dtsi
@@ -966,6 +966,15 @@
};
};
+ pdc: interrupt-controller@b220000 {
+ compatible = "qcom,sdm845-pdc";
+ reg = <0xb220000 0x30000>;
+ qcom,pdc-ranges = <0 480 94>, <94 609 15>, <115 630 7>;
+ #interrupt-cells = <2>;
+ interrupt-parent = <&intc>;
+ interrupt-controller;
+ };
+
spmi_bus: spmi@c440000 {
compatible = "qcom,spmi-pmic-arb";
reg = <0xc440000 0x1100>,
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 3+ messages in thread
* [PATCH v3 2/2] dt-bindings/interrupt-controller: pdc: fix example to match actual bindings
2018-08-24 19:11 [PATCH v3 1/2] arm64: dts: msm: add PDC device bindings for sdm845 Lina Iyer
@ 2018-08-24 19:11 ` Lina Iyer
2018-08-29 0:26 ` Rob Herring
0 siblings, 1 reply; 3+ messages in thread
From: Lina Iyer @ 2018-08-24 19:11 UTC (permalink / raw)
To: marc.zyngier, bjorn.andersson, sboyd, evgreen, linus.walleij
Cc: rplsssn, linux-kernel, linux-arm-msm, rnayak, devicetree,
andy.gross, dianders, Lina Iyer
The PDC map should use the GIC SPI port and not the vector. GIC
internally adds 32 to SPI hwirq numbers.
Fixes: 1ae8862e27e ("dt-bindings/interrupt-controller: pdc: Describe PDC device binding")
Signed-off-by: Lina Iyer <ilina@codeaurora.org>
---
.../devicetree/bindings/interrupt-controller/qcom,pdc.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
index 0b2c97ddb520..30f2f10d75e9 100644
--- a/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
+++ b/Documentation/devicetree/bindings/interrupt-controller/qcom,pdc.txt
@@ -61,13 +61,13 @@ Example:
pdc: interrupt-controller@b220000 {
compatible = "qcom,sdm845-pdc";
reg = <0xb220000 0x30000>;
- qcom,pdc-ranges = <0 512 94>, <94 641 15>, <115 662 7>;
+ qcom,pdc-ranges = <0 480 94>, <94 609 15>, <115 630 7>;
#interrupt-cells = <2>;
interrupt-parent = <&intc>;
interrupt-controller;
};
-DT binding of a device that wants to use the GIC SPI 514 as a wakeup
+DT binding of a device that wants to use the GIC SPI 482 as a wakeup
interrupt, must do -
wake-device {
--
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
a Linux Foundation Collaborative Project
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3 2/2] dt-bindings/interrupt-controller: pdc: fix example to match actual bindings
2018-08-24 19:11 ` [PATCH v3 2/2] dt-bindings/interrupt-controller: pdc: fix example to match actual bindings Lina Iyer
@ 2018-08-29 0:26 ` Rob Herring
0 siblings, 0 replies; 3+ messages in thread
From: Rob Herring @ 2018-08-29 0:26 UTC (permalink / raw)
To: Lina Iyer
Cc: marc.zyngier, bjorn.andersson, sboyd, evgreen, linus.walleij,
rplsssn, linux-kernel, linux-arm-msm, rnayak, devicetree,
andy.gross, dianders, Lina Iyer
On Fri, 24 Aug 2018 13:11:11 -0600, Lina Iyer wrote:
> The PDC map should use the GIC SPI port and not the vector. GIC
> internally adds 32 to SPI hwirq numbers.
>
> Fixes: 1ae8862e27e ("dt-bindings/interrupt-controller: pdc: Describe PDC device binding")
> Signed-off-by: Lina Iyer <ilina@codeaurora.org>
> ---
> .../devicetree/bindings/interrupt-controller/qcom,pdc.txt | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-29 0:26 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-24 19:11 [PATCH v3 1/2] arm64: dts: msm: add PDC device bindings for sdm845 Lina Iyer
2018-08-24 19:11 ` [PATCH v3 2/2] dt-bindings/interrupt-controller: pdc: fix example to match actual bindings Lina Iyer
2018-08-29 0:26 ` Rob Herring
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).