From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61879C433F5 for ; Sat, 25 Aug 2018 13:28:13 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0947A21655 for ; Sat, 25 Aug 2018 13:28:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 0947A21655 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726835AbeHYRHJ (ORCPT ); Sat, 25 Aug 2018 13:07:09 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:47252 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726537AbeHYRHJ (ORCPT ); Sat, 25 Aug 2018 13:07:09 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1ftYbl-00036w-5G; Sat, 25 Aug 2018 21:28:05 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1ftYbh-0003OC-JA; Sat, 25 Aug 2018 21:28:01 +0800 Date: Sat, 25 Aug 2018 21:28:01 +0800 From: Herbert Xu To: Dave Watson Cc: Mauro Rossi , linux-crypto@vger.kernel.org, Junaid Shahid , linux-kernel@vger.kernel.org, Stephan Mueller Subject: Re: [PATCH] crypto: aesni - Use unaligned loads from gcm_context_data Message-ID: <20180825132801.fnsr72cx4s2ohovy@gondor.apana.org.au> References: <20180815172942.mkk56gh6poqgjgnb@davejwatson-mba.local> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180815172942.mkk56gh6poqgjgnb@davejwatson-mba.local> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Aug 15, 2018 at 10:29:42AM -0700, Dave Watson wrote: > A regression was reported bisecting to 1476db2d12 > "Move HashKey computation from stack to gcm_context". That diff > moved HashKey computation from the stack, which was explicitly aligned > in the asm, to a struct provided from the C code, depending on > AESNI_ALIGN_ATTR for alignment. It appears some compilers may not > align this struct correctly, resulting in a crash on the movdqa > instruction when attempting to encrypt or decrypt data. > > Fix by using unaligned loads for the HashKeys. On modern > hardware there is no perf difference between the unaligned and > aligned loads. All other accesses to gcm_context_data already use > unaligned loads. > > Reported-by: Mauro Rossi > Fixes: 1476db2d12 ("Move HashKey computation from stack to gcm_context") > Signed-off-by: Dave Watson Patch applied. Thanks. -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt