archive mirror
 help / color / mirror / Atom feed
From: Matthew Wilcox <>
To: Naoya Horiguchi <>
	Andrew Morton <>
Subject: Re: [PATCH v1] tools/vm/slabinfo.c: fix sign-compare warning
Date: Sat, 25 Aug 2018 19:21:14 -0700	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On Fri, Aug 24, 2018 at 06:32:14PM +0900, Naoya Horiguchi wrote:
> -	int hwcache_align, object_size, objs_per_slab;
> -	int sanity_checks, slab_size, store_user, trace;
> +	int hwcache_align, objs_per_slab;
> +	int sanity_checks, store_user, trace;
>  	int order, poison, reclaim_account, red_zone;
> +	unsigned int object_size, slab_size;

Surely hwcache_align and objs_per_slab can't be negative either?
Nor the other three.  So maybe convert all seven of these variables to
unsigned int?

  reply	other threads:[~2018-08-26  2:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-24  9:32 Naoya Horiguchi
2018-08-26  2:21 ` Matthew Wilcox [this message]
2018-08-26 23:49   ` [PATCH v2] " Naoya Horiguchi

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \ \
    --subject='Re: [PATCH v1] tools/vm/slabinfo.c: fix sign-compare warning' \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is a public inbox, see mirroring instructions
on how to clone and mirror all data and code used for this inbox