From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,URIBL_BLOCKED,USER_AGENT_NEOMUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 9F661C433F5 for ; Mon, 27 Aug 2018 06:13:41 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 546AF21735 for ; Mon, 27 Aug 2018 06:13:41 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 546AF21735 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=gondor.apana.org.au Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727021AbeH0J6v (ORCPT ); Mon, 27 Aug 2018 05:58:51 -0400 Received: from orcrist.hmeau.com ([104.223.48.154]:48214 "EHLO deadmen.hmeau.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726776AbeH0J6v (ORCPT ); Mon, 27 Aug 2018 05:58:51 -0400 Received: from gondobar.mordor.me.apana.org.au ([192.168.128.4] helo=gondobar) by deadmen.hmeau.com with esmtps (Exim 4.89 #2 (Debian)) id 1fuAmG-0003Vb-DG; Mon, 27 Aug 2018 14:13:28 +0800 Received: from herbert by gondobar with local (Exim 4.89) (envelope-from ) id 1fuAmE-00058A-RO; Mon, 27 Aug 2018 14:13:26 +0800 Date: Mon, 27 Aug 2018 14:13:26 +0800 From: Herbert Xu To: "Martin K. Petersen" Cc: Jeff.Lien@wdc.com, ard.biesheuvel@linaro.org, david.darrington@wdc.com, hch@infradead.org, jeff.furlong@wdc.com, linux-block@vger.kernel.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org, linux-scsi@vger.kernel.org, tim.c.chen@linux.intel.com Subject: Re: [PATCH 2/4] crc-t10dif: Pick better transform if one becomes available Message-ID: <20180827061326.oqclv2sncoayt3al@gondor.apana.org.au> References: <20180825061205.ygrjjazkooqghrqy@gondor.apana.org.au> <20180826024006.13800-1-martin.petersen@oracle.com> <20180826024006.13800-2-martin.petersen@oracle.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180826024006.13800-2-martin.petersen@oracle.com> User-Agent: NeoMutt/20170113 (1.7.2) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Aug 25, 2018 at 07:40:04PM -0700, Martin K. Petersen wrote: > > +static int crc_t10dif_rehash(struct notifier_block *self, unsigned long val, void *data) > +{ > + struct crypto_alg *alg = data; > + struct crypto_shash *new, *old; > + > + if (val != CRYPTO_MSG_ALG_LOADED || > + static_key_false(&crct10dif_fallback) || > + strncmp(alg->cra_name, CRC_T10DIF_STRING, strlen(CRC_T10DIF_STRING))) > + return 0; > + > + spin_lock(&crc_t10dif_mutex); > + old = rcu_dereference_protected(crct10dif_tfm, > + lockdep_is_held(&crc_t10dif_mutex)); > + if (!old) { > + spin_unlock(&crc_t10dif_mutex); > + return 0; > + } > + new = crypto_alloc_shash("crct10dif", 0, 0); You cannot allocate crypto tfm objects while holding a spin lock because they need to allocate memory with GFP_KERNEL. How about using a mutex? Cheers, -- Email: Herbert Xu Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt