From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,MAILING_LIST_MULTI,SPF_PASS,T_DKIMWL_WL_HIGH,URIBL_BLOCKED, USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CE41AC433F5 for ; Mon, 27 Aug 2018 12:50:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7D453208B7 for ; Mon, 27 Aug 2018 12:50:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=kernel.org header.i=@kernel.org header.b="lao52W3s" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7D453208B7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727510AbeH0Qh0 (ORCPT ); Mon, 27 Aug 2018 12:37:26 -0400 Received: from mail.kernel.org ([198.145.29.99]:56294 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726851AbeH0QhZ (ORCPT ); Mon, 27 Aug 2018 12:37:25 -0400 Received: from jouet.infradead.org (unknown [189.112.165.9]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 266F9208B6; Mon, 27 Aug 2018 12:50:52 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1535374252; bh=mcQAdb2aC1RIfglllB18xAd98uOK7Lxjy9PRauqzCOU=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=lao52W3s58q7IIeamvgPBqqKcu8jnOKgTuJfxeoiNaiaHHNYT7tpdO4ynMgfseOal 5W6WutTRXflXpK0GecrIO4SQtrxmQBngsMOk62ngAeztaRwtw7SeZJ1wsIIKY82obj UXVDj09xS8zbMtFiJDxBQqEJ5/OgK6eozW/HoO18= Received: by jouet.infradead.org (Postfix, from userid 1000) id B4FA1141C3F; Mon, 27 Aug 2018 09:50:49 -0300 (-03) Date: Mon, 27 Aug 2018 09:50:49 -0300 From: Arnaldo Carvalho de Melo To: Kim Phillips Cc: Ravi Bangoria , Anton Blanchard , Robin Murphy , Alexander Shishkin , Christian Borntraeger , Mark Rutland , Peter Zijlstra , Taeung Song , Ingo Molnar , Jiri Olsa , Namhyung Kim , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, perf group Subject: Re: [PATCH] perf annotate: fix parsing aarch64 branch instructions after objdump update Message-ID: <20180827125049.GD22309@kernel.org> References: <20180823191047.9260992844205984b75e6721@arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20180823191047.9260992844205984b75e6721@arm.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.9.2 (2017-12-15) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Em Thu, Aug 23, 2018 at 07:10:47PM -0500, Kim Phillips escreveu: > Starting with binutils 2.28, aarch64 objdump adds comments to the > disassembly output to show the alternative names of a condition code [1]. > > It is assumed that commas in objdump comments could occur in other arches > now or in the future, so this fix is arch-independent. > > The fix could have been done with arm64 specific jump__parse and > jump__scnprintf functions, but the jump__scnprintf instruction would > have to have its comment character be a literal, since the scnprintf > functions cannot receive a struct arch easily. > > This inconvenience also applies to the generic jump__scnprintf, which > is why we add a raw_comment pointer to struct ins_operands, so the > __parse function assigns it to be re-used by its corresponding __scnprintf > function. > > Example differences in 'perf annotate --stdio2' output on an > aarch64 perf.data file: > > BEFORE: → b.cs ffff200008133d1c // b.hs, dffff7ecc47b > AFTER : ↓ b.cs 18c > > BEFORE: → b.cc ffff200008d8d9cc // b.lo, b.ul, dffff727295b > AFTER : ↓ b.cc 31c > > The branch target labels 18c and 31c also now appear in the output: > > BEFORE: add x26, x29, #0x80 > AFTER : 18c: add x26, x29, #0x80 > > BEFORE: add x21, x21, #0x8 > AFTER : 31c: add x21, x21, #0x8 > > The Fixes: tag below is added so stable branches will get the update; it > doesn't necessarily mean that commit was broken at the time, rather it > didn't withstand the aarch64 objdump update. > > Tested no difference in output for sample x86_64, power arch perf.data files. > > [1] https://sourceware.org/git/gitweb.cgi?p=binutils-gdb.git;a=commit;h=bb7eff5206e4795ac79c177a80fe9f4630aaf730 > > Cc: Ravi Bangoria > Cc: Anton Blanchard > Cc: Robin Murphy > Cc: Alexander Shishkin > Cc: Christian Borntraeger > Cc: Mark Rutland > Cc: Peter Zijlstra > Cc: Taeung Song > Cc: Ingo Molnar > Cc: Arnaldo Carvalho de Melo > Cc: Alexander Shishkin > Cc: Jiri Olsa > Cc: Namhyung Kim > Fixes: b13bbeee5ee6 ("perf annotate: Fix branch instruction with multiple operands") > Signed-off-by: Kim Phillips > --- > tools/perf/util/annotate.c | 17 ++++++++++++++++- > tools/perf/util/annotate.h | 1 + > 2 files changed, 17 insertions(+), 1 deletion(-) > > diff --git a/tools/perf/util/annotate.c b/tools/perf/util/annotate.c > index e32ead4744bd..b83897dafbb0 100644 > --- a/tools/perf/util/annotate.c > +++ b/tools/perf/util/annotate.c > @@ -282,7 +282,8 @@ bool ins__is_call(const struct ins *ins) > return ins->ops == &call_ops || ins->ops == &s390_call_ops; > } > > -static int jump__parse(struct arch *arch __maybe_unused, struct ins_operands *ops, struct map_symbol *ms) > +static int jump__parse(struct arch *arch, struct ins_operands *ops, > + struct map_symbol *ms) Try to refrain from reflowing, what you need to do here is just to remove that __maybe_unused. > { > struct map *map = ms->map; > struct symbol *sym = ms->sym; > @@ -291,6 +292,15 @@ static int jump__parse(struct arch *arch __maybe_unused, struct ins_operands *op > }; > const char *c = strchr(ops->raw, ','); > u64 start, end; > + > + /* > + * Prevent from matching commas in the comment section, e.g.: > + * ffff200008446e70: b.cs ffff2000084470f4 // b.hs, b.nlast > + */ > + ops->raw_comment = strchr(ops->raw, arch->objdump.comment_char); > + if (c && ops->raw_comment && c > ops->raw_comment) > + c = NULL; > + > /* > * Examples of lines to parse for the _cpp_lex_token@@Base > * function: > @@ -367,6 +377,11 @@ static int jump__scnprintf(struct ins *ins, char *bf, size_t size, > return scnprintf(bf, size, "%-6s %s", ins->name, ops->target.sym->name); > > c = strchr(ops->raw, ','); > + > + /* Prevent from matching commas in the comment section */ > + if (ops->raw_comment && c && c > ops->raw_comment) > + c = NULL; This is equivalent to the previous test, but why do it differently? Since both are open coded equivalents, why not do something like: c = validate_comma(c, ops); That would translate to: static inline const char *validate_comma(const char *c, ops) { return c > ops->raw_comment ? NULL : c; } Which should be a third equivalent form to check if c, having been found, is after ops->raw_comment, if there is a raw_comment? - Arnaldo > + > if (c != NULL) { > const char *c2 = strchr(c + 1, ','); > > diff --git a/tools/perf/util/annotate.h b/tools/perf/util/annotate.h > index 005a5fe8a8c6..5399ba2321bb 100644 > --- a/tools/perf/util/annotate.h > +++ b/tools/perf/util/annotate.h > @@ -22,6 +22,7 @@ struct ins { > > struct ins_operands { > char *raw; > + char *raw_comment; > struct { > char *raw; > char *name; > -- > 2.17.1