From: Andrew Lunn <andrew@lunn.ch>
To: Florian Fainelli <f.fainelli@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org,
Rob Herring <robh+dt@kernel.org>,
Mark Rutland <mark.rutland@arm.com>, Ray Jui <rjui@broadcom.com>,
Scott Branden <sbranden@broadcom.com>,
Jon Mason <jonmason@broadcom.com>,
"maintainer:BROADCOM IPROC ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>,
rmk+kernel@armlinux.org.uk
Subject: Re: [PATCH 1/3] ARM: dts: NSP: Enable SFP on bcm958625hr
Date: Mon, 27 Aug 2018 23:09:16 +0200 [thread overview]
Message-ID: <20180827210916.GP27483@lunn.ch> (raw)
In-Reply-To: <4a0e7b46-f7b6-3e9a-5f67-8160537482c8@gmail.com>
On Mon, Aug 27, 2018 at 01:52:42PM -0700, Florian Fainelli wrote:
> On 08/27/2018 01:35 PM, Andrew Lunn wrote:
> >> @@ -210,6 +228,17 @@
> >> reg = <4>;
> >> };
> >>
> >> + port@5 {
> >> + label = "sfp";
> >> + phy-mode = "sgmii";
> >> + reg = <5>;
> >> + sfp = <&sfp>;
> >> + fixed-link {
> >> + speed = <1000>;
> >> + full-duplex;
> >> + };
> >
> > Hi Florian
> >
> > You might want to add a comment about why you are using fixed-link and
> > sgmii, which seems very odd. Is it even correct?
>
> Probably not, this is kind of left over from before adding the sfp
> phandle, but if I do remove it, and I can see the DSA slave network
> device fail to initialize, likely because we destroy the PHYLINK instance.
>
> AFAIR, when we talked about this with Russell, I did not see why we had
> to comment out the following:
>
> diff --git a/net/dsa/slave.c b/net/dsa/slave.c
> index 962c4fd338ba..f3ae16dbf8d8 100644
> --- a/net/dsa/slave.c
> +++ b/net/dsa/slave.c
> @@ -1227,7 +1227,7 @@ static int dsa_slave_phy_setup(struct net_device
> *slave_dev)
> netdev_err(slave_dev,
> "failed to connect to port %d: %d\n",
> dp->index, ret);
> - phylink_destroy(dp->pl);
> + //phylink_destroy(dp->pl);
> return ret;
> }
> }
>
> maybe you know?
Hi Florian
I didn't need anything like this for the mv88e6xxx. I had patches
merged in -rc1 to make SFF work connected to the mv88e6390. The DT
change was not merged, but it is here:
https://patchwork.ozlabs.org/patch/955635/
+ port@9 {
+ reg = <9>;
+ label = "sff2";
+ phy-mode = "sgmii";
+ managed = "in-band-status";
+ sfp = <&sff2>;
+ };
Andrew
next prev parent reply other threads:[~2018-08-27 21:09 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 20:03 [PATCH 0/3] ARM: NSP updates to support switch interrupts/SFP Florian Fainelli
2018-08-27 20:03 ` [PATCH 1/3] ARM: dts: NSP: Enable SFP on bcm958625hr Florian Fainelli
2018-08-27 20:35 ` Andrew Lunn
2018-08-27 20:52 ` Florian Fainelli
2018-08-27 21:09 ` Andrew Lunn [this message]
2018-08-27 21:17 ` Florian Fainelli
2018-08-27 21:31 ` Andrew Lunn
2018-08-27 21:09 ` Florian Fainelli
2018-08-27 22:26 ` Russell King - ARM Linux
2018-08-27 22:36 ` Florian Fainelli
2018-08-27 20:03 ` [PATCH 2/3] dt-bindings: net: dsa: Document B53 SRAB interrupts and registers Florian Fainelli
2018-08-27 20:03 ` [PATCH 3/3] ARM: dts: NSP: Wire up switch interrupts Florian Fainelli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180827210916.GP27483@lunn.ch \
--to=andrew@lunn.ch \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=f.fainelli@gmail.com \
--cc=jonmason@broadcom.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=rjui@broadcom.com \
--cc=rmk+kernel@armlinux.org.uk \
--cc=robh+dt@kernel.org \
--cc=sbranden@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).