From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS,USER_AGENT_MUTT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id BABE2C433F4 for ; Tue, 28 Aug 2018 12:36:25 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7B7B22088E for ; Tue, 28 Aug 2018 12:36:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 7B7B22088E Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=linuxfoundation.org Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727842AbeH1Q1u (ORCPT ); Tue, 28 Aug 2018 12:27:50 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:34938 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726120AbeH1Q1u (ORCPT ); Tue, 28 Aug 2018 12:27:50 -0400 Received: from localhost (unknown [104.153.224.167]) by mail.linuxfoundation.org (Postfix) with ESMTPSA id DD549E3E; Tue, 28 Aug 2018 12:36:18 +0000 (UTC) Date: Tue, 28 Aug 2018 14:36:07 +0200 From: Greg KH To: "Ahmed S. Darwish" Cc: Stephen Rothwell , John Joseph , linux-kernel@vger.kernel.org, Simon Que , Rob Springer , devel@linuxdriverproject.org, Andrew Morton , Todd Poynor , Linus Torvalds Subject: Re: [GIT PULL] Staging/IIO driver patches for 4.19-rc1 Message-ID: <20180828123607.GB13441@kroah.com> References: <20180818155724.GA22569@kroah.com> <20180828103817.GB1397@do-kernel> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20180828103817.GB1397@do-kernel> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Aug 28, 2018 at 10:38:17AM +0000, Ahmed S. Darwish wrote: > [ re-send; forgotten lkml CC added; sorry ] > > Hi, > > On Sat, 18 Aug 2018 17:57:24 +0200, Greg KH wrote: > [...] > > addition of some new IIO drivers. Also added was a "gasket" driver from > > Google that needs loads of work and the erofs filesystem. > > > > Why are we adding __a whole new in-kernel framework__ for > developing basic user-space drivers? > > We already have a frameowrk for that, and it's UIO. [1] The UIO > code is a very stable and simple subsystem; it's also heavily used > in the embedded industry.. As Todd said, the code will end up being a simple UIO driver, if even that big, in th end. It is just going to take him a while to constantly refactor things until he achieves that goal... > I've looked at the gasket documentation [2], and the first user > of this new in-kernel API [3], and this is almost replicating UIO > it's not funny. [4] True, the gasket APIs adds some extra new > conveniences (PCI BAR re-mapping, MSI, ..), but there's no > technical reason this cannot be added to the UIO code instead. {shh} That's my plan :) > More-over, the exposed user-space API is just some ioctls. So if > google hase some shipped user-space code that is using this, > hopefully the driver can still be re-implemented through UIO > without changing these bits.. Odds are there is shipped code with that, which is why it will evolve over time this way and could not all happen at once. thanks for reviewing it, greg k-h