* [PATCH v3] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB
@ 2018-08-28 14:32 Liu Xiang
2018-08-28 14:36 ` Boris Brezillon
2018-10-12 12:47 ` Boris Brezillon
0 siblings, 2 replies; 3+ messages in thread
From: Liu Xiang @ 2018-08-28 14:32 UTC (permalink / raw)
To: linux-mtd
Cc: linux-kernel, stable, han.xu, marek.vasut, dwmw2,
computersforpeace, boris.brezillon, richard, liuxiang_1999,
Liu Xiang
If the size of spi-nor flash is larger than 16MB, the read_opcode
is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
cause read operation fail.
Fixes: e46ecda764dc ("mtd: spi-nor: Add Freescale QuadSPI driver")
Cc: <stable@vger.kernel.org>
Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
---
Changes in v3:
move changelog position.
drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
index 7d9620c..64304a3 100644
--- a/drivers/mtd/spi-nor/fsl-quadspi.c
+++ b/drivers/mtd/spi-nor/fsl-quadspi.c
@@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
{
switch (cmd) {
case SPINOR_OP_READ_1_1_4:
+ case SPINOR_OP_READ_1_1_4_4B:
return SEQID_READ;
case SPINOR_OP_WREN:
return SEQID_WREN;
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH v3] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB
2018-08-28 14:32 [PATCH v3] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB Liu Xiang
@ 2018-08-28 14:36 ` Boris Brezillon
2018-10-12 12:47 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2018-08-28 14:36 UTC (permalink / raw)
To: Liu Xiang
Cc: linux-mtd, linux-kernel, stable, han.xu, marek.vasut, dwmw2,
computersforpeace, richard, liuxiang_1999
On Tue, 28 Aug 2018 22:32:57 +0800
Liu Xiang <liu.xiang6@zte.com.cn> wrote:
> If the size of spi-nor flash is larger than 16MB, the read_opcode
> is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
> return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
> cause read operation fail.
>
> Fixes: e46ecda764dc ("mtd: spi-nor: Add Freescale QuadSPI driver")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
> ---
>
> Changes in v3:
> move changelog position.
Normally you should keep the v2 changelog here. No need to resend just
for that.
>
> drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 7d9620c..64304a3 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
> {
> switch (cmd) {
> case SPINOR_OP_READ_1_1_4:
> + case SPINOR_OP_READ_1_1_4_4B:
> return SEQID_READ;
> case SPINOR_OP_WREN:
> return SEQID_WREN;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH v3] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB
2018-08-28 14:32 [PATCH v3] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB Liu Xiang
2018-08-28 14:36 ` Boris Brezillon
@ 2018-10-12 12:47 ` Boris Brezillon
1 sibling, 0 replies; 3+ messages in thread
From: Boris Brezillon @ 2018-10-12 12:47 UTC (permalink / raw)
To: Liu Xiang
Cc: linux-mtd, richard, linux-kernel, stable, marek.vasut,
liuxiang_1999, han.xu, computersforpeace, dwmw2
On Tue, 28 Aug 2018 22:32:57 +0800
Liu Xiang <liu.xiang6@zte.com.cn> wrote:
> If the size of spi-nor flash is larger than 16MB, the read_opcode
> is set to SPINOR_OP_READ_1_1_4_4B, and fsl_qspi_get_seqid() will
> return -EINVAL when cmd is SPINOR_OP_READ_1_1_4_4B. This can
> cause read operation fail.
>
> Fixes: e46ecda764dc ("mtd: spi-nor: Add Freescale QuadSPI driver")
> Cc: <stable@vger.kernel.org>
> Signed-off-by: Liu Xiang <liu.xiang6@zte.com.cn>
Queued to spi-nor/next.
Thanks,
Boris
> ---
>
> Changes in v3:
> move changelog position.
>
> drivers/mtd/spi-nor/fsl-quadspi.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/mtd/spi-nor/fsl-quadspi.c b/drivers/mtd/spi-nor/fsl-quadspi.c
> index 7d9620c..64304a3 100644
> --- a/drivers/mtd/spi-nor/fsl-quadspi.c
> +++ b/drivers/mtd/spi-nor/fsl-quadspi.c
> @@ -478,6 +478,7 @@ static int fsl_qspi_get_seqid(struct fsl_qspi *q, u8 cmd)
> {
> switch (cmd) {
> case SPINOR_OP_READ_1_1_4:
> + case SPINOR_OP_READ_1_1_4_4B:
> return SEQID_READ;
> case SPINOR_OP_WREN:
> return SEQID_WREN;
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-10-12 12:47 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-28 14:32 [PATCH v3] mtd: spi-nor: fsl-quadspi: fix read error for flash size larger than 16MB Liu Xiang
2018-08-28 14:36 ` Boris Brezillon
2018-10-12 12:47 ` Boris Brezillon
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).