* [PATCH net-next] genetlink: constify genl_err_attr() argument
@ 2018-08-28 16:51 Michal Kubecek
2018-08-30 2:43 ` David Miller
0 siblings, 1 reply; 2+ messages in thread
From: Michal Kubecek @ 2018-08-28 16:51 UTC (permalink / raw)
To: David S. Miller; +Cc: netdev, linux-kernel
genl_err_attr() sets netlink_ext_ack::bad_attr which is a pointer to const
struct nlattr so make the attr argument also const.
Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
---
include/net/genetlink.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/include/net/genetlink.h b/include/net/genetlink.h
index decf6012a401..aa2e5888f18d 100644
--- a/include/net/genetlink.h
+++ b/include/net/genetlink.h
@@ -112,7 +112,7 @@ static inline void genl_info_net_set(struct genl_info *info, struct net *net)
#define GENL_SET_ERR_MSG(info, msg) NL_SET_ERR_MSG((info)->extack, msg)
static inline int genl_err_attr(struct genl_info *info, int err,
- struct nlattr *attr)
+ const struct nlattr *attr)
{
info->extack->bad_attr = attr;
--
2.18.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH net-next] genetlink: constify genl_err_attr() argument
2018-08-28 16:51 [PATCH net-next] genetlink: constify genl_err_attr() argument Michal Kubecek
@ 2018-08-30 2:43 ` David Miller
0 siblings, 0 replies; 2+ messages in thread
From: David Miller @ 2018-08-30 2:43 UTC (permalink / raw)
To: mkubecek; +Cc: netdev, linux-kernel
From: Michal Kubecek <mkubecek@suse.cz>
Date: Tue, 28 Aug 2018 18:51:58 +0200 (CEST)
> genl_err_attr() sets netlink_ext_ack::bad_attr which is a pointer to const
> struct nlattr so make the attr argument also const.
>
> Signed-off-by: Michal Kubecek <mkubecek@suse.cz>
Applied.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2018-08-30 2:43 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-28 16:51 [PATCH net-next] genetlink: constify genl_err_attr() argument Michal Kubecek
2018-08-30 2:43 ` David Miller
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).