* [PATCH] Staging: One Laptop Per Child: add function argument names
@ 2018-08-09 16:23 Arkadiusz Lis
2018-08-27 17:52 ` Greg KH
0 siblings, 1 reply; 3+ messages in thread
From: Arkadiusz Lis @ 2018-08-09 16:23 UTC (permalink / raw)
To: jfrederich, dsd, jon.nettleton, gregkh; +Cc: devel, linux-kernel, Arkadiusz Lis
Add function argument names to pointers to functions
in struct dcon_platform_data: init, set_dconload and read_status
This commit removes checkpatch.pl warning.
Signed-off-by: Arkadiusz Lis <areklis909@gmail.com>
---
drivers/staging/olpc_dcon/olpc_dcon.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h
index fa89bb9..0ce1a7a 100644
--- a/drivers/staging/olpc_dcon/olpc_dcon.h
+++ b/drivers/staging/olpc_dcon/olpc_dcon.h
@@ -91,10 +91,10 @@ struct dcon_priv {
};
struct dcon_platform_data {
- int (*init)(struct dcon_priv *);
+ int (*init)(struct dcon_priv *dcon);
void (*bus_stabilize_wiggle)(void);
- void (*set_dconload)(int);
- int (*read_status)(u8 *);
+ void (*set_dconload)(int val);
+ int (*read_status)(u8 *status);
};
#include <linux/interrupt.h>
--
1.9.1
^ permalink raw reply related [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: One Laptop Per Child: add function argument names
2018-08-09 16:23 [PATCH] Staging: One Laptop Per Child: add function argument names Arkadiusz Lis
@ 2018-08-27 17:52 ` Greg KH
2018-08-28 19:34 ` Arkadiusz Lis
0 siblings, 1 reply; 3+ messages in thread
From: Greg KH @ 2018-08-27 17:52 UTC (permalink / raw)
To: Arkadiusz Lis; +Cc: jfrederich, dsd, jon.nettleton, devel, linux-kernel
On Thu, Aug 09, 2018 at 06:23:59PM +0200, Arkadiusz Lis wrote:
> Add function argument names to pointers to functions
> in struct dcon_platform_data: init, set_dconload and read_status
> This commit removes checkpatch.pl warning.
>
> Signed-off-by: Arkadiusz Lis <areklis909@gmail.com>
> ---
> drivers/staging/olpc_dcon/olpc_dcon.h | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h
> index fa89bb9..0ce1a7a 100644
> --- a/drivers/staging/olpc_dcon/olpc_dcon.h
> +++ b/drivers/staging/olpc_dcon/olpc_dcon.h
> @@ -91,10 +91,10 @@ struct dcon_priv {
> };
>
> struct dcon_platform_data {
> - int (*init)(struct dcon_priv *);
> + int (*init)(struct dcon_priv *dcon);
> void (*bus_stabilize_wiggle)(void);
> - void (*set_dconload)(int);
> - int (*read_status)(u8 *);
> + void (*set_dconload)(int val);
> + int (*read_status)(u8 *status);
> };
>
> #include <linux/interrupt.h>
> --
> 1.9.1
>
> _______________________________________________
> devel mailing list
> devel@linuxdriverproject.org
> http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
Patch did not apply to my tree at all. Please rebase against the latest
linux-next and resend.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] Staging: One Laptop Per Child: add function argument names
2018-08-27 17:52 ` Greg KH
@ 2018-08-28 19:34 ` Arkadiusz Lis
0 siblings, 0 replies; 3+ messages in thread
From: Arkadiusz Lis @ 2018-08-28 19:34 UTC (permalink / raw)
To: Greg KH; +Cc: jfrederich, jon.nettleton, dsd, devel, linux-kernel
On Mon, Aug 27, 2018 at 07:52:13PM +0200, Greg KH wrote:
> On Thu, Aug 09, 2018 at 06:23:59PM +0200, Arkadiusz Lis wrote:
> > Add function argument names to pointers to functions
> > in struct dcon_platform_data: init, set_dconload and read_status
> > This commit removes checkpatch.pl warning.
> >
> > Signed-off-by: Arkadiusz Lis <areklis909@gmail.com>
> > ---
> > drivers/staging/olpc_dcon/olpc_dcon.h | 6 +++---
> > 1 file changed, 3 insertions(+), 3 deletions(-)
> >
> > diff --git a/drivers/staging/olpc_dcon/olpc_dcon.h b/drivers/staging/olpc_dcon/olpc_dcon.h
> > index fa89bb9..0ce1a7a 100644
> > --- a/drivers/staging/olpc_dcon/olpc_dcon.h
> > +++ b/drivers/staging/olpc_dcon/olpc_dcon.h
> > @@ -91,10 +91,10 @@ struct dcon_priv {
> > };
> >
> > struct dcon_platform_data {
> > - int (*init)(struct dcon_priv *);
> > + int (*init)(struct dcon_priv *dcon);
> > void (*bus_stabilize_wiggle)(void);
> > - void (*set_dconload)(int);
> > - int (*read_status)(u8 *);
> > + void (*set_dconload)(int val);
> > + int (*read_status)(u8 *status);
> > };
> >
> > #include <linux/interrupt.h>
> > --
> > 1.9.1
> >
> > _______________________________________________
> > devel mailing list
> > devel@linuxdriverproject.org
> > http://driverdev.linuxdriverproject.org/mailman/listinfo/driverdev-devel
>
> Patch did not apply to my tree at all. Please rebase against the latest
> linux-next and resend.
>
> thanks,
>
> greg k-h
Hi Greg,
It seems this issue was already fixed with commit 9b59883c14267ccf2c3f9d260bd6fb0dc9478fa1, hence the conflict.
My patch is redundant
Regards,
Arek
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2018-08-28 19:35 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-08-09 16:23 [PATCH] Staging: One Laptop Per Child: add function argument names Arkadiusz Lis
2018-08-27 17:52 ` Greg KH
2018-08-28 19:34 ` Arkadiusz Lis
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).