From: "Jérémie Galarneau" <jeremie.galarneau@efficios.com> To: linux-kernel@vger.kernel.org Cc: "Jérémie Galarneau" <jeremie.galarneau@efficios.com>, "Jiri Olsa" <jolsa@kernel.org>, "Arnaldo Carvalho de Melo" <acme@redhat.com>, "Peter Zijlstra" <peterz@infradead.org>, "Ingo Molnar" <mingo@redhat.com>, "Alexander Shishkin" <alexander.shishkin@linux.intel.com> Subject: [PATCH] perf tools: Initialize perf_data_file fd field Date: Wed, 29 Aug 2018 16:16:48 -0400 [thread overview] Message-ID: <20180829201648.19588-1-jeremie.galarneau@efficios.com> (raw) Building the perf CTF converter fails with gcc 4.8.4 on Ubuntu 14.04 with the following error: error: missing initializer for field ‘fd’ of ‘struct perf_data_file’ [-Werror=missing-field-initializers] Per 4b838b0d and the ensuing discussion on the mailing list, it appears that this affects other distributions and gcc versions. Signed-off-by: Jérémie Galarneau <jeremie.galarneau@efficios.com> Cc: Jiri Olsa <jolsa@kernel.org> Cc: Arnaldo Carvalho de Melo <acme@redhat.com> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Ingo Molnar <mingo@redhat.com> Cc: Alexander Shishkin <alexander.shishkin@linux.intel.com> --- tools/perf/util/data-convert-bt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/perf/util/data-convert-bt.c b/tools/perf/util/data-convert-bt.c index abd38abf1d91..f75d4aa612c5 100644 --- a/tools/perf/util/data-convert-bt.c +++ b/tools/perf/util/data-convert-bt.c @@ -1578,7 +1578,7 @@ int bt_convert__perf2ctf(const char *input, const char *path, { struct perf_session *session; struct perf_data data = { - .file.path = input, + .file = { .path = input, .fd = -1 }, .mode = PERF_DATA_MODE_READ, .force = opts->force, }; -- 2.18.0
next reply other threads:[~2018-08-29 20:23 UTC|newest] Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top 2018-08-29 20:16 Jérémie Galarneau [this message] 2018-09-05 16:09 ` Jiri Olsa 2018-09-18 18:07 ` Jérémie Galarneau 2018-09-18 18:59 ` Arnaldo Carvalho de Melo 2018-09-25 9:33 ` [tip:perf/core] " tip-bot for Jérémie Galarneau
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox Avoid top-posting and favor interleaved quoting: https://en.wikipedia.org/wiki/Posting_style#Interleaved_style * Reply using the --to, --cc, and --in-reply-to switches of git-send-email(1): git send-email \ --in-reply-to=20180829201648.19588-1-jeremie.galarneau@efficios.com \ --to=jeremie.galarneau@efficios.com \ --cc=acme@redhat.com \ --cc=alexander.shishkin@linux.intel.com \ --cc=jolsa@kernel.org \ --cc=linux-kernel@vger.kernel.org \ --cc=mingo@redhat.com \ --cc=peterz@infradead.org \ --subject='Re: [PATCH] perf tools: Initialize perf_data_file fd field' \ /path/to/YOUR_REPLY https://kernel.org/pub/software/scm/git/docs/git-send-email.html * If your mail client supports setting the In-Reply-To header via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).