From: Dan Carpenter <dan.carpenter@oracle.com>
To: John Whitmore <johnfwhitmore@gmail.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 01/21] staging:rtl8192u: Rename AdvCoding - Style
Date: Thu, 30 Aug 2018 11:26:28 +0300 [thread overview]
Message-ID: <20180830082628.ff5x3tzvd2wdrbir@mwanda> (raw)
In-Reply-To: <20180830082305.umqtq3fdexlyvn65@mwanda>
On Thu, Aug 30, 2018 at 11:23:05AM +0300, Dan Carpenter wrote:
> On Wed, Aug 29, 2018 at 09:35:27PM +0100, John Whitmore wrote:
> > Rename the bit field element AdvCoding, as it causes a checkpatch issue
> > with CamelCase naming. As the element is not actually used in code it
> > has been renamed to 'not_used_adv_coding'.
> >
> > The single line of code which initialises the bit has been removed,
> > as the field is unused.
> >
> > This is a purely coding style change which should have no impact
> > on runtime code execution.
> >
> > Signed-off-by: John Whitmore <johnfwhitmore@gmail.com>
> > ---
> > drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h | 2 +-
> > drivers/staging/rtl8192u/ieee80211/rtl819x_HTProc.c | 1 -
> > 2 files changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
> > index 64d5359cf7e2..66a0274077d3 100644
> > --- a/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
> > +++ b/drivers/staging/rtl8192u/ieee80211/rtl819x_HT.h
> > @@ -39,7 +39,7 @@ enum ht_extension_chan_offset {
> >
> > struct ht_capability_ele {
> > //HT capability info
> > - u8 AdvCoding:1;
> > + u8 not_used_adv_coding:1;
>
> I can't review any more of this patchset when this is the first line...
>
That email wasn't very clear. If you think some of your patches are
going to be more controversial than others, put them at the very end so
we can at least apply part of the patchset.
regards,
dan carpenter
next prev parent reply other threads:[~2018-08-30 8:26 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-29 20:35 [PATCH 00/21] staging:rtl8192u: Refactor ht_capability_ele - Style John Whitmore
2018-08-29 20:35 ` [PATCH 01/21] staging:rtl8192u: Rename AdvCoding " John Whitmore
2018-08-29 21:14 ` Joe Perches
2018-08-29 21:21 ` Larry Finger
2018-08-29 21:55 ` John Whitmore
2018-08-30 22:34 ` Joe Perches
2018-08-31 22:27 ` John Whitmore
2018-08-30 8:23 ` Dan Carpenter
2018-08-30 8:26 ` Dan Carpenter [this message]
2018-08-30 21:35 ` John Whitmore
2018-08-31 7:24 ` Dan Carpenter
2018-09-10 15:08 ` Greg KH
2018-08-29 20:35 ` [PATCH 02/21] staging:rtl8192u: Rename ChlWidth " John Whitmore
2018-08-29 20:35 ` [PATCH 03/21] staging:rtl8192u: Rename MimoPwrSave " John Whitmore
2018-08-29 20:35 ` [PATCH 04/21] staging:rtl8192u: Rename GreenField " John Whitmore
2018-08-29 20:35 ` [PATCH 05/21] staging:rtl8192u: Rename ShortGI20Mhz " John Whitmore
2018-08-29 20:35 ` [PATCH 06/21] staging:rtl8192u: Rename ShortGI40Mhz " John Whitmore
2018-08-29 20:35 ` [PATCH 07/21] staging:rtl8192u: Rename TxSTBC " John Whitmore
2018-08-29 20:35 ` [PATCH 08/21] staging:rtl8192u: Rename RxSTBC " John Whitmore
2018-08-29 20:35 ` [PATCH 09/21] staging:rtl8192u: Rename DelayBA " John Whitmore
2018-08-29 20:35 ` [PATCH 10/21] staging:rtl8192u: Rename MaxAMSDUSize " John Whitmore
2018-08-29 20:35 ` [PATCH 11/21] staging:rtl8192u: Rename DssCCk " John Whitmore
2018-08-29 20:35 ` [PATCH 12/21] staging:rtl8192u: Rename PSMP " John Whitmore
2018-08-29 20:35 ` [PATCH 13/21] staging:rtl8192u: Rename Rsvd1 " John Whitmore
2018-08-29 20:35 ` [PATCH 14/21] staging:rtl8192u: Rename LSigTxopProtect " John Whitmore
2018-08-29 20:35 ` [PATCH 15/21] staging:rtl8192u: Rename MaxRxAMPDUFactor " John Whitmore
2018-08-29 20:35 ` [PATCH 16/21] staging:rtl8192u: Rename MPDUDensity " John Whitmore
2018-08-29 20:35 ` [PATCH 17/21] staging:rtl8192u: Rename Rsvd2 " John Whitmore
2018-08-29 20:35 ` [PATCH 18/21] staging:rtl8192u: Rename MCS " John Whitmore
2018-08-29 20:35 ` [PATCH 19/21] staging:rtl8192u: Rename ExtHTCapInfo " John Whitmore
2018-08-29 20:35 ` [PATCH 20/21] staging:rtl8192u: Rename TxBFCap " John Whitmore
2018-08-29 20:35 ` [PATCH 21/21] staging:rtl8192u: Rename ASCap " John Whitmore
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830082628.ff5x3tzvd2wdrbir@mwanda \
--to=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=johnfwhitmore@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).