linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Jiri Olsa <jolsa@redhat.com>
To: Andi Kleen <andi@firstfloor.org>
Cc: acme@kernel.org, jolsa@kernel.org, adrian.hunter@intel.com,
	linux-kernel@vger.kernel.org
Subject: Re: Make perf script easier to use for itrace
Date: Thu, 30 Aug 2018 10:42:36 +0200	[thread overview]
Message-ID: <20180830084236.GB16691@krava> (raw)
In-Reply-To: <20180829171834.6590-1-andi@firstfloor.org>

On Wed, Aug 29, 2018 at 10:18:24AM -0700, Andi Kleen wrote:

SNIP

> 
> Filter by a ftrace style graph function:
> 
>  % perf script --graph-function group_sched_in --call-trace
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])          group_sched_in
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])              __x86_indirect_thunk_rax
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])              event_sched_in.isra.107
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])                  perf_event_set_state.part.71
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])                      perf_event_update_time
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])                  perf_pmu_disable
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])                  perf_log_itrace_start
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])                  __x86_indirect_thunk_rax
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])                      perf_event_update_userpage
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])                          calc_timer_values
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])                              sched_clock_cpu
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])                          __x86_indirect_thunk_rax
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])                          arch_perf_update_userpage
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])                              __fentry__
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])                              using_native_sched_clock
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])                              sched_clock_stable
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])                  perf_pmu_enable
>                 perf   900 [000] 194167.205652203: ([kernel.kallsyms])              __x86_indirect_thunk_rax
> 
> 
> Also available in
> git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git pt/easy-script-2

got compile error over your branch, might be one of the new fancy gcc8 checksm not sure
  gcc version 8.1.1 20180712 (Red Hat 8.1.1-5) (GCC) 

jirka


---
[jolsa@krava perf]$ make JOBS=1
  BUILD:   Doing 'make -j1' parallel build
  CC       builtin-script.o
builtin-script.c: In function ‘parse_output_fields’:
builtin-script.c:2571:22: error: array subscript 7 is above array bounds of ‘struct <anonymous>[7]’ [-Werror=array-bounds]
     output[j].fields &= ~all_output_options[i].field;
                      ^~
builtin-script.c:2571:22: error: array subscript 7 is above array bounds of ‘struct <anonymous>[7]’ [-Werror=array-bounds]
     output[j].fields &= ~all_output_options[i].field;
     ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
builtin-script.c:2574:10: error: array subscript 7 is above array bounds of ‘struct <anonymous>[7]’ [-Werror=array-bounds]
    output[j].user_set = true;
    ~~~~~~^~~
builtin-script.c:2575:10: error: array subscript 7 is above array bounds of ‘struct <anonymous>[7]’ [-Werror=array-bounds]
    output[j].wildcard_set = true;
    ~~~~~~^~~
builtin-script.c: In function ‘parse_output_fields.constprop’:
builtin-script.c:2571:22: error: array subscript 7 is above array bounds of ‘struct <anonymous>[7]’ [-Werror=array-bounds]
     output[j].fields &= ~all_output_options[i].field;
                      ^~
builtin-script.c:2571:22: error: array subscript 7 is above array bounds of ‘struct <anonymous>[7]’ [-Werror=array-bounds]
     output[j].fields &= ~all_output_options[i].field;
     ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
builtin-script.c:2574:10: error: array subscript 7 is above array bounds of ‘struct <anonymous>[7]’ [-Werror=array-bounds]
    output[j].user_set = true;
    ~~~~~~^~~
builtin-script.c:2575:10: error: array subscript 7 is above array bounds of ‘struct <anonymous>[7]’ [-Werror=array-bounds]
    output[j].wildcard_set = true;
    ~~~~~~^~~
cc1: all warnings being treated as errors
mv: cannot stat './.builtin-script.o.tmp': No such file or directory
make[3]: *** [/home/jolsa/kernel/linux-perf/tools/build/Makefile.build:97: builtin-script.o] Error 1
make[2]: *** [Makefile.perf:507: perf-in.o] Error 2
make[1]: *** [Makefile.perf:206: sub-make] Error 2
make: *** [Makefile:70: all] Error 2


  parent reply	other threads:[~2018-08-30  8:42 UTC|newest]

Thread overview: 30+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-29 17:18 Make perf script easier to use for itrace Andi Kleen
2018-08-29 17:18 ` [PATCH v1 01/10] perf tools: Report itrace options in help Andi Kleen
2018-08-30  8:56   ` Jiri Olsa
2018-08-29 17:18 ` [PATCH v1 02/10] tools, pager: Support overwriting the pager Andi Kleen
2018-08-29 17:18 ` [PATCH v1 03/10] tools, perf, script: Add --insn-trace for instruction decoding Andi Kleen
2018-08-30  8:56   ` Jiri Olsa
2018-08-30 13:55     ` Andi Kleen
2018-09-19 18:12   ` Arnaldo Carvalho de Melo
2018-09-19 20:02     ` Andi Kleen
2018-09-19 20:38       ` Arnaldo Carvalho de Melo
2018-08-29 17:18 ` [PATCH v1 04/10] perf, tools, script: Allow sym and dso without ip, addr Andi Kleen
2018-08-30  8:56   ` Jiri Olsa
2018-08-29 17:18 ` [PATCH v1 05/10] perf, tools, script: Print DSO for callindent Andi Kleen
2018-08-30  8:57   ` Jiri Olsa
2018-08-29 17:18 ` [PATCH v1 06/10] tools, perf, script: Set user_set/wildcard_set for +- fields in -F Andi Kleen
2018-08-30  8:59   ` Jiri Olsa
2018-08-29 17:18 ` [PATCH v1 07/10] perf, tools, script: Implement - for typed fields Andi Kleen
2018-08-29 17:18 ` [PATCH v1 08/10] perf, tools, script: Make itrace script default to all calls Andi Kleen
2018-08-29 17:18 ` [PATCH v1 09/10] tools, perf, script: Add --call-trace and --call-ret-trace Andi Kleen
2018-08-29 17:18 ` [PATCH v1 10/10] tools, perf, script: Implement --graph-function Andi Kleen
2018-08-30  8:42 ` Jiri Olsa [this message]
2018-08-31 22:01 Make perf script easier to use for itrace Andi Kleen
2018-08-31 22:54 ` Kim Phillips
2018-09-03  7:31   ` Jiri Olsa
2018-09-03 15:50   ` Andi Kleen
2018-09-03  7:52 ` Jiri Olsa
2018-09-03 16:22 Andi Kleen
2018-09-14  3:10 Andi Kleen
2018-09-18 12:32 Andi Kleen
2018-09-20 18:05 Andi Kleen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20180830084236.GB16691@krava \
    --to=jolsa@redhat.com \
    --cc=acme@kernel.org \
    --cc=adrian.hunter@intel.com \
    --cc=andi@firstfloor.org \
    --cc=jolsa@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).