From: Paul Burton <paul.burton@mips.com>
To: Mike Rapoport <rppt@linux.vnet.ibm.com>
Cc: Serge Semin <fancer.lancer@gmail.com>,
Ralf Baechle <ralf@linux-mips.org>,
James Hogan <jhogan@kernel.org>, Huacai Chen <chenhc@lemote.com>,
Michal Hocko <mhocko@kernel.org>,
linux-mips@linux-mips.org, linux-mm@kvack.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH RESEND] mips: switch to NO_BOOTMEM
Date: Thu, 30 Aug 2018 14:48:57 -0700 [thread overview]
Message-ID: <20180830214856.cwqyjksz36ujxydm@pburton-laptop> (raw)
In-Reply-To: <1535356775-20396-1-git-send-email-rppt@linux.vnet.ibm.com>
Hi Mike,
On Mon, Aug 27, 2018 at 10:59:35AM +0300, Mike Rapoport wrote:
> MIPS already has memblock support and all the memory is already registered
> with it.
>
> This patch replaces bootmem memory reservations with memblock ones and
> removes the bootmem initialization.
>
> Signed-off-by: Mike Rapoport <rppt@linux.vnet.ibm.com>
> ---
>
> arch/mips/Kconfig | 1 +
> arch/mips/kernel/setup.c | 89 +++++-----------------------------
> arch/mips/loongson64/loongson-3/numa.c | 34 ++++++-------
> arch/mips/sgi-ip27/ip27-memory.c | 11 ++---
> 4 files changed, 33 insertions(+), 102 deletions(-)
Thanks for working on this. Unfortunately it breaks boot for at least a
32r6el_defconfig kernel on QEMU:
$ qemu-system-mips64el \
-M boston \
-kernel arch/mips/boot/vmlinux.gz.itb \
-serial stdio \
-append "earlycon=uart8250,mmio32,0x17ffe000,115200 console=ttyS0,115200 debug memblock=debug mminit_loglevel=4"
[ 0.000000] Linux version 4.19.0-rc1-00008-g82d0f342eecd (pburton@pburton-laptop) (gcc version 8.1.0 (GCC)) #23 SMP Thu Aug 30 14:38:06 PDT 2018
[ 0.000000] CPU0 revision is: 0001a900 (MIPS I6400)
[ 0.000000] FPU revision is: 20f30300
[ 0.000000] MSA revision is: 00000300
[ 0.000000] MIPS: machine is img,boston
[ 0.000000] Determined physical RAM map:
[ 0.000000] memory: 10000000 @ 00000000 (usable)
[ 0.000000] memory: 30000000 @ 90000000 (usable)
[ 0.000000] earlycon: uart8250 at MMIO32 0x17ffe000 (options '115200')
[ 0.000000] bootconsole [uart8250] enabled
[ 0.000000] memblock_reserve: [0x00000000-0x009a8fff] setup_arch+0x224/0x718
[ 0.000000] memblock_reserve: [0x01360000-0x01361ca7] setup_arch+0x3d8/0x718
[ 0.000000] Initrd not found or empty - disabling initrd
[ 0.000000] memblock_virt_alloc_try_nid: 7336 bytes align=0x40 nid=-1 from=0x00000000 max_addr=0x00000000 early_init_dt_alloc_memory_arch+0x20/0x2c
[ 0.000000] memblock_reserve: [0xbfffe340-0xbfffffe7] memblock_virt_alloc_internal+0x120/0x1ec
<hang>
It looks like we took a TLB store exception after calling memset() with
a bogus address from memblock_virt_alloc_try_nid() or something inlined
into it.
This was with your patch applied atop the mips-next branch from [1],
which is currently at commit 35d017947401 ("MIPS: ralink: Add rt3352
SPI_CS1 pinmux").
Thanks,
Paul
[1] git://git.kernel.org/pub/scm/linux/kernel/git/mips/linux.git
next prev parent reply other threads:[~2018-08-30 21:49 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-08-27 7:59 [PATCH RESEND] mips: switch to NO_BOOTMEM Mike Rapoport
2018-08-30 21:48 ` Paul Burton [this message]
2018-08-31 21:17 ` Mike Rapoport
2018-09-05 17:47 ` Paul Burton
2018-09-05 18:37 ` Mike Rapoport
[not found] ` <CAMPMW8rJ4qC8iaRa0jTjgZmiYf51AaricrgCg1aNx-Ez6=zT0g@mail.gmail.com>
2018-09-06 5:30 ` Mike Rapoport
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20180830214856.cwqyjksz36ujxydm@pburton-laptop \
--to=paul.burton@mips.com \
--cc=chenhc@lemote.com \
--cc=fancer.lancer@gmail.com \
--cc=jhogan@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@kernel.org \
--cc=ralf@linux-mips.org \
--cc=rppt@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).